Merge branch 'vs-allow-to-reassign-immer-draft' into 'master'

Remove redundant no-param-reassign from Immer drafts

See merge request gitlab-org/gitlab!56320

.eslintrc.yml

@@ -43,6 +43,17 @@ rules:
   promise/always-return: off
   promise/no-callback-in-promise: off
   '@gitlab/no-global-event-off': error
+  no-param-reassign:
+    - error
+    - props: true
+      ignorePropertyModificationsFor:
+        - acc
+        - accumulator
+        - el
+        - element
+        - state
+      ignorePropertyModificationsForRegex:
+        - '^draft'
   import/order:
     - error
     - groups:

app/assets/javascripts/access_tokens/components/projects_token_selector.vue

@@ -104,10 +104,8 @@ export default {
           const { projects: previousProjects } = previousResult;
 
           return produce(previousResult, (draftData) => {
-            /* eslint-disable no-param-reassign */
             draftData.projects.nodes = [...previousProjects.nodes, ...newProjects.nodes];
             draftData.projects.pageInfo = newProjects.pageInfo;
-            /* eslint-enable no-param-reassign */
           });
         },
       });

app/assets/javascripts/alerts_settings/graphql.js

@@ -27,10 +27,8 @@ const resolvers = {
       const sourceData = cache.readQuery({ query: getCurrentIntegrationQuery });
       const data = produce(sourceData, (draftData) => {
         if (id === null) {
-          // eslint-disable-next-line no-param-reassign
           draftData.currentIntegration = null;
         } else {
-          // eslint-disable-next-line no-param-reassign
           draftData.currentIntegration = {
             id,
             name,

app/assets/javascripts/alerts_settings/utils/cache_updates.js

@@ -15,7 +15,6 @@ const deleteIntegrationFromStore = (store, query, { httpIntegrationDestroy }, va
   });
 
   const data = produce(sourceData, (draftData) => {
-    // eslint-disable-next-line no-param-reassign
     draftData.project.alertManagementIntegrations.nodes = draftData.project.alertManagementIntegrations.nodes.filter(
       ({ id }) => id !== integration.id,
     );
@@ -46,7 +45,6 @@ const addIntegrationToStore = (
   });
 
   const data = produce(sourceData, (draftData) => {
-    // eslint-disable-next-line no-param-reassign
     draftData.project.alertManagementIntegrations.nodes = [
       integration,
       ...draftData.project.alertManagementIntegrations.nodes,
@@ -72,7 +70,6 @@ const addHttpIntegrationToStore = (store, query, { httpIntegrationCreate }, vari
   });
 
   const data = produce(sourceData, (draftData) => {
-    // eslint-disable-next-line no-param-reassign
     draftData.project.alertManagementHttpIntegrations.nodes = [
       integration,
       ...draftData.project.alertManagementHttpIntegrations.nodes,

app/assets/javascripts/design_management/graphql.js

@@ -20,7 +20,6 @@ const resolvers = {
       const sourceData = cache.readQuery({ query: activeDiscussionQuery });
 
       const data = produce(sourceData, (draftData) => {
-        // eslint-disable-next-line no-param-reassign
         draftData.activeDiscussion = {
           __typename: 'ActiveDiscussion',
           id,

app/assets/javascripts/design_management/utils/cache_update.js

@@ -41,7 +41,6 @@ const addNewVersionToStore = (store, query, version) => {
   const sourceData = store.readQuery(query);
 
   const data = produce(sourceData, (draftData) => {
-    // eslint-disable-next-line no-param-reassign
     draftData.project.issue.designCollection.versions.nodes = [
       version,
       ...draftData.project.issue.designCollection.versions.nodes,
@@ -168,7 +167,6 @@ const addNewDesignToStore = (store, designManagementUpload, query) => {
         nodes: newVersions,
       },
     };
-    // eslint-disable-next-line no-param-reassign
     draftData.project.issue.designCollection = updatedDesigns;
   });
 
@@ -182,7 +180,6 @@ const moveDesignInStore = (store, designManagementMove, query) => {
   const sourceData = store.readQuery(query);
 
   const data = produce(sourceData, (draftData) => {
-    // eslint-disable-next-line no-param-reassign
     draftData.project.issue.designCollection.designs =
       designManagementMove.designCollection.designs;
   });

app/assets/javascripts/jira_import/utils/cache_update.js

@@ -21,8 +21,7 @@ export const addInProgressImportToStore = (store, jiraImportStart, fullPath) =>
   store.writeQuery({
     ...queryDetails,
     data: produce(sourceData, (draftData) => {
-      draftData.project.jiraImportStatus = IMPORT_STATE.SCHEDULED; // eslint-disable-line no-param-reassign
-      // eslint-disable-next-line no-param-reassign
+      draftData.project.jiraImportStatus = IMPORT_STATE.SCHEDULED;
       draftData.project.jiraImports.nodes = [
         ...sourceData.project.jiraImports.nodes,
         jiraImportStart.jiraImport,

app/assets/javascripts/monitoring/components/charts/anomaly.vue

@@ -86,7 +86,6 @@ export default {
       const originalMetricQuery = this.graphData.metrics[0];
 
       const metricQuery = produce(originalMetricQuery, (draftQuery) => {
-        // eslint-disable-next-line no-param-reassign
         draftQuery.result[0].values = draftQuery.result[0].values.map(([x, y]) => [
           x,
           y + this.yOffset,

app/assets/javascripts/packages_and_registries/settings/group/graphql/utils/cache_update.js

@@ -9,7 +9,6 @@ export const updateGroupPackageSettings = (fullPath) => (client, { data: updated
   const sourceData = client.readQuery(queryAndParams);
 
   const data = produce(sourceData, (draftState) => {
-    // eslint-disable-next-line no-param-reassign
     draftState.group.packageSettings = {
       ...updatedData.updateNamespacePackageSettings.packageSettings,
     };

app/assets/javascripts/registry/explorer/components/delete_image.vue

@@ -29,7 +29,6 @@ export default {
       });
 
       const data = produce(sourceData, (draftState) => {
-        // eslint-disable-next-line no-param-reassign
         draftState.containerRepository.status =
           destroyContainerRepository.containerRepository.status;
       });

app/assets/javascripts/registry/settings/graphql/utils/cache_update.js

@@ -9,7 +9,6 @@ export const updateContainerExpirationPolicy = (projectPath) => (client, { data:
   const sourceData = client.readQuery(queryAndParams);
 
   const data = produce(sourceData, (draftState) => {
-    // eslint-disable-next-line no-param-reassign
     draftState.project.containerExpirationPolicy = {
       ...updatedData.updateContainerExpirationPolicy.containerExpirationPolicy,
     };

app/assets/javascripts/sidebar/components/confidential/sidebar_confidentiality_widget.vue

@@ -95,7 +95,6 @@ export default {
       });
 
       const data = produce(sourceData, (draftData) => {
-        // eslint-disable-next-line no-param-reassign
         draftData.workspace.issuable.confidential = !this.confidential;
       });
 

app/assets/javascripts/vue_merge_request_widget/components/states/work_in_progress.vue

@@ -87,11 +87,8 @@ export default {
             });
 
             const data = produce(sourceData, (draftState) => {
-              // eslint-disable-next-line no-param-reassign
               draftState.project.mergeRequest.mergeableDiscussionsState = mergeableDiscussionsState;
-              // eslint-disable-next-line no-param-reassign
               draftState.project.mergeRequest.workInProgress = workInProgress;
-              // eslint-disable-next-line no-param-reassign
               draftState.project.mergeRequest.title = title;
             });
 

app/assets/javascripts/vue_shared/alert_details/components/sidebar/sidebar_todo.vue

@@ -116,7 +116,6 @@ export default {
       });
 
       const data = produce(sourceData, (draftData) => {
-        // eslint-disable-next-line no-param-reassign
         draftData.project.alertManagementAlerts.nodes[0].todos.nodes = [];
       });
 

app/assets/javascripts/vue_shared/alert_details/index.js

@@ -20,7 +20,6 @@ export default (selector) => {
       toggleSidebarStatus: (_, __, { cache }) => {
         const sourceData = cache.readQuery({ query: sidebarStatusQuery });
         const data = produce(sourceData, (draftData) => {
-          // eslint-disable-next-line no-param-reassign
           draftData.sidebarStatus = !draftData.sidebarStatus;
         });
         cache.writeQuery({ query: sidebarStatusQuery, data });

ee/app/assets/javascripts/analytics/devops_report/devops_adoption/utils/cache_updates.js

@@ -7,7 +7,6 @@ export const addSegmentToCache = (store, segment) => {
   });
 
   const data = produce(sourceData, (draftData) => {
-    // eslint-disable-next-line no-param-reassign
     draftData.devopsAdoptionSegments.nodes = [...draftData.devopsAdoptionSegments.nodes, segment];
   });
 
@@ -23,7 +22,6 @@ export const deleteSegmentFromCache = (store, segmentId) => {
   });
 
   const updatedData = produce(sourceData, (draftData) => {
-    // eslint-disable-next-line no-param-reassign
     draftData.devopsAdoptionSegments.nodes = draftData.devopsAdoptionSegments.nodes.filter(
       ({ id }) => id !== segmentId,
     );

ee/app/assets/javascripts/analytics/repository_analytics/components/select_projects_dropdown.vue

@@ -112,7 +112,6 @@ export default {
           },
           updateQuery(previousResult, { fetchMoreResult }) {
             const results = produce(fetchMoreResult, (draftData) => {
-              // eslint-disable-next-line no-param-reassign
               draftData.group.projects.nodes = [
                 ...previousResult.group.projects.nodes,
                 ...draftData.group.projects.nodes,

ee/app/assets/javascripts/oncall_schedules/graphql.js

@@ -11,7 +11,6 @@ const resolvers = {
     updateShiftTimeUnitWidth: (_, { shiftTimeUnitWidth = 0 }, { cache }) => {
       const sourceData = cache.readQuery({ query: getShiftTimeUnitWidthQuery });
       const data = produce(sourceData, (draftData) => {
-        // eslint-disable-next-line no-param-reassign
         draftData.shiftTimeUnitWidth = shiftTimeUnitWidth;
       });
       cache.writeQuery({ query: getShiftTimeUnitWidthQuery, data });

ee/app/assets/javascripts/oncall_schedules/utils/cache_updates.js

@@ -47,7 +47,6 @@ const deleteScheduleFromStore = (store, query, { oncallScheduleDestroy }, variab
   });
 
   const data = produce(sourceData, (draftData) => {
-    // eslint-disable-next-line no-param-reassign
     draftData.project.incidentManagementOncallSchedules.nodes = draftData.project.incidentManagementOncallSchedules.nodes.filter(
       ({ id }) => id !== schedule.id,
     );
@@ -72,7 +71,6 @@ const updateScheduleFromStore = (store, query, { oncallScheduleUpdate }, variabl
   });
 
   const data = produce(sourceData, (draftData) => {
-    // eslint-disable-next-line no-param-reassign
     draftData.project.incidentManagementOncallSchedules.nodes = draftData.project.incidentManagementOncallSchedules.nodes.map(
       (scheduleToUpdate) => {
         return scheduleToUpdate.iid === schedule.iid ? schedule : scheduleToUpdate;

ee/app/assets/javascripts/security_configuration/dast_profiles/graphql/cache_utils.js

@@ -31,7 +31,6 @@ export const removeProfile = ({ profileId, profileType, store, queryBody }) => {
   const sourceData = store.readQuery(queryBody);
 
   const data = produce(sourceData, (draftState) => {
-    // eslint-disable-next-line no-param-reassign
     draftState.project[profileType].edges = draftState.project[profileType].edges.filter(
       ({ node }) => {
         return node.id !== profileId;

ee/app/assets/javascripts/security_dashboard/components/first_class_group_security_dashboard_vulnerabilities.vue

@@ -84,7 +84,6 @@ export default {
           variables: { after: this.pageInfo.endCursor },
           updateQuery: (previousResult, { fetchMoreResult }) => {
             return produce(fetchMoreResult, (draftData) => {
-              // eslint-disable-next-line no-param-reassign
               draftData.group.vulnerabilities.nodes = [
                 ...previousResult.group.vulnerabilities.nodes,
                 ...draftData.group.vulnerabilities.nodes,

ee/app/assets/javascripts/security_dashboard/components/first_class_instance_security_dashboard_vulnerabilities.vue

@@ -82,7 +82,6 @@ export default {
           variables: { after: this.pageInfo.endCursor },
           updateQuery: (previousResult, { fetchMoreResult }) => {
             return produce(fetchMoreResult, (draftData) => {
-              // eslint-disable-next-line no-param-reassign
               draftData.vulnerabilities.nodes = [
                 ...previousResult.vulnerabilities.nodes,
                 ...draftData.vulnerabilities.nodes,

ee/app/assets/javascripts/security_dashboard/components/first_class_project_manager/project_manager.vue

@@ -82,7 +82,6 @@ export default {
               const newProject = results.addProjectToSecurityDashboard.project;
 
               const data = produce(sourceData, (draftData) => {
-                // eslint-disable-next-line no-param-reassign
                 draftData.instanceSecurityDashboard.projects.nodes = [
                   ...draftData.instanceSecurityDashboard.projects.nodes,
                   {
@@ -157,7 +156,6 @@ export default {
             const sourceData = store.readQuery({ query: projectsQuery });
 
             const data = produce(sourceData, (draftData) => {
-              // eslint-disable-next-line no-param-reassign
               draftData.instanceSecurityDashboard.projects.nodes = draftData.instanceSecurityDashboard.projects.nodes.filter(
                 (curr) => curr.id !== id,
               );

ee/app/assets/javascripts/security_dashboard/components/project_vulnerabilities.vue

@@ -112,7 +112,6 @@ export default {
           variables: { after: this.pageInfo.endCursor },
           updateQuery: (previousResult, { fetchMoreResult }) => {
             return produce(fetchMoreResult, (draftData) => {
-              // eslint-disable-next-line no-param-reassign
               draftData.project.vulnerabilities.nodes = [
                 ...previousResult.project.vulnerabilities.nodes,
                 ...draftData.project.vulnerabilities.nodes,

ee/app/assets/javascripts/threat_monitoring/components/alerts/alerts_list.vue

@@ -103,7 +103,6 @@ export default {
           variables: { nextPageCursor: this.pageInfo.endCursor },
           updateQuery: (previousResult, { fetchMoreResult }) => {
             const results = produce(fetchMoreResult, (draftData) => {
-              // eslint-disable-next-line no-param-reassign
               draftData.project.alertManagementAlerts.nodes = [
                 ...previousResult.project.alertManagementAlerts.nodes,
                 ...draftData.project.alertManagementAlerts.nodes,