Merge branch 'rails-save-bang-22' into 'master'

Fix Rails/SaveBang offenses for spec/requests/api/pages/*

See merge request gitlab-org/gitlab!41324

.rubocop_todo.yml

@@ -1196,9 +1196,6 @@ Rails/SaveBang:
     - 'spec/requests/api/merge_request_diffs_spec.rb'
     - 'spec/requests/api/merge_requests_spec.rb'
     - 'spec/requests/api/notes_spec.rb'
-    - 'spec/requests/api/pages/internal_access_spec.rb'
-    - 'spec/requests/api/pages/private_access_spec.rb'
-    - 'spec/requests/api/pages/public_access_spec.rb'
     - 'spec/requests/api/pipeline_schedules_spec.rb'
     - 'spec/requests/api/project_import_spec.rb'
     - 'spec/requests/api/project_milestones_spec.rb'

changelogs/unreleased/rails-save-bang-22.yml

+---
+title: Fix Rails/SaveBang offenses for spec/requests/api/pages/*
+merge_request: 41324
+author:
+type: fixed

spec/requests/api/pages/internal_access_spec.rb

@@ -72,7 +72,7 @@ RSpec.describe "Internal Project Pages Access" do
 
       with_them do
         before do
-          project.project_feature.update(pages_access_level: pages_access_level)
+          project.project_feature.update!(pages_access_level: pages_access_level)
         end
         it "correct return value" do
           if !with_user.nil?

spec/requests/api/pages/private_access_spec.rb

@@ -72,7 +72,7 @@ RSpec.describe "Private Project Pages Access" do
 
       with_them do
         before do
-          project.project_feature.update(pages_access_level: pages_access_level)
+          project.project_feature.update!(pages_access_level: pages_access_level)
         end
         it "correct return value" do
           if !with_user.nil?

spec/requests/api/pages/public_access_spec.rb

@@ -72,7 +72,7 @@ RSpec.describe "Public Project Pages Access" do
 
       with_them do
         before do
-          project.project_feature.update(pages_access_level: pages_access_level)
+          project.project_feature.update!(pages_access_level: pages_access_level)
         end
         it "correct return value" do
           if !with_user.nil?