Merge branch '207080-combine-send-email-calls' into 'master'

Move send_email? to IncidentManagement::Settings

Closes #207080

See merge request gitlab-org/gitlab!37808

app/services/concerns/incident_management/settings.rb

 # frozen_string_literal: true
+
 module IncidentManagement
   module Settings
     include Gitlab::Utils::StrongMemoize
 
+    delegate :send_email?, to: :incident_management_setting
+
     def incident_management_setting
       strong_memoize(:incident_management_setting) do
         project.incident_management_setting ||

app/services/projects/alerting/notify_service.rb

@@ -58,10 +58,6 @@ module Projects
         AlertManagement::Alert.not_resolved.for_fingerprint(project, fingerprint).first
       end
 
-      def send_email?
-        incident_management_setting.send_email?
-      end
-
       def process_incident_issues(alert)
         return if alert.issue
 

app/services/projects/prometheus/alerts/notify_service.rb

@@ -42,10 +42,6 @@ module Projects
           Gitlab::Utils::DeepSize.new(params).valid?
         end
 
-        def send_email?
-          incident_management_setting.send_email && firings.any?
-        end
-
         def firings
           @firings ||= alerts_by_status('firing')
         end
@@ -125,6 +121,8 @@ module Projects
         end
 
         def send_alert_email
+          return unless firings.any?
+
           notification_service
             .async
             .prometheus_alerts_fired(project, firings)