Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5d43c09d
Commit
5d43c09d
authored
5 years ago
by
Dan Davison
Committed by
Ramya Authappan
5 years ago
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Refactor ambiguous page-object names
Remove Rubocop disable statements
parent
e36c32c4
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
24 additions
and
24 deletions
+24
-24
qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb
...s/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb
+4
-4
qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb
...ures/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb
+11
-11
qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb
...ee/browser_ui/1_manage/project/project_audit_logs_spec.rb
+2
-2
qa/qa/specs/features/ee/browser_ui/secure/security_reports_spec.rb
...cs/features/ee/browser_ui/secure/security_reports_spec.rb
+4
-4
qa/qa/tools/revoke_all_personal_access_tokens.rb
qa/qa/tools/revoke_all_personal_access_tokens.rb
+3
-3
No files found.
qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb
View file @
5d43c09d
...
...
@@ -86,13 +86,13 @@ module QA
project
.
visit!
Page
::
Project
::
Menu
.
perform
(
&
:go_to_members_settings
)
Page
::
Project
::
Settings
::
Members
.
perform
do
|
page
|
# rubocop:disable QA/AmbiguousPageObjectName
page
.
invite_group
(
@group
.
path
)
Page
::
Project
::
Settings
::
Members
.
perform
do
|
members
|
members
.
invite_group
(
@group
.
path
)
end
Page
::
Project
::
Menu
.
perform
(
&
:go_to_members_settings
)
Page
::
Project
::
Settings
::
Members
.
perform
do
|
page
|
# rubocop:disable QA/AmbiguousPageObjectName
page
.
remove_group
(
@group
.
path
)
Page
::
Project
::
Settings
::
Members
.
perform
do
|
members
|
members
.
remove_group
(
@group
.
path
)
end
@group
.
visit!
...
...
This diff is collapsed.
Click to expand it.
qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb
View file @
5d43c09d
...
...
@@ -68,10 +68,10 @@ module QA
Page
::
Group
::
Menu
.
perform
(
&
:go_to_ldap_sync_settings
)
EE
::
Page
::
Group
::
Settings
::
LDAPSync
.
perform
do
|
page
|
# rubocop:disable QA/AmbiguousPageObjectName
page
.
set_sync_method
(
'LDAP Group cn'
)
page
.
set_group_cn
(
'Engineering'
)
page
.
click_add_sync_button
EE
::
Page
::
Group
::
Settings
::
LDAPSync
.
perform
do
|
settings
|
settings
.
set_sync_method
(
'LDAP Group cn'
)
settings
.
set_group_cn
(
'Engineering'
)
settings
.
click_add_sync_button
end
Page
::
Group
::
Menu
.
perform
(
&
:click_group_members_item
)
...
...
@@ -118,9 +118,9 @@ module QA
Page
::
Group
::
Menu
.
perform
(
&
:go_to_ldap_sync_settings
)
EE
::
Page
::
Group
::
Settings
::
LDAPSync
.
perform
do
|
page
|
# rubocop:disable QA/AmbiguousPageObjectName
page
.
set_user_filter
(
'(&(objectClass=person)(cn=HR*))'
)
page
.
click_add_sync_button
EE
::
Page
::
Group
::
Settings
::
LDAPSync
.
perform
do
|
settings
|
settings
.
set_user_filter
(
'(&(objectClass=person)(cn=HR*))'
)
settings
.
click_add_sync_button
end
Page
::
Group
::
Menu
.
perform
(
&
:click_group_members_item
)
...
...
@@ -171,10 +171,10 @@ module QA
end
def
verify_users_synced
(
expected_users
)
EE
::
Page
::
Group
::
Members
.
perform
do
|
page
|
# rubocop:disable QA/AmbiguousPageObjectName
page
.
click_sync_now
users_synchronised
=
page
.
retry_until
(
reload:
true
)
do
expected_users
.
map
{
|
user
|
page
.
has_content?
(
user
)
}.
all?
EE
::
Page
::
Group
::
Members
.
perform
do
|
members
|
members
.
click_sync_now
users_synchronised
=
members
.
retry_until
(
reload:
true
)
do
expected_users
.
map
{
|
user
|
members
.
has_content?
(
user
)
}.
all?
end
expect
(
users_synchronised
).
to
be_truthy
end
...
...
This diff is collapsed.
Click to expand it.
qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb
View file @
5d43c09d
...
...
@@ -40,8 +40,8 @@ module QA
@project
.
visit!
Page
::
Project
::
Menu
.
perform
(
&
:go_to_members_settings
)
Page
::
Project
::
Settings
::
Members
.
perform
do
|
page
|
# rubocop:disable QA/AmbiguousPageObjectName
page
.
add_member
(
user
.
username
)
Page
::
Project
::
Settings
::
Members
.
perform
do
|
members
|
members
.
add_member
(
user
.
username
)
end
end
...
...
This diff is collapsed.
Click to expand it.
qa/qa/specs/features/ee/browser_ui/secure/security_reports_spec.rb
View file @
5d43c09d
...
...
@@ -115,8 +115,8 @@ module QA
it
'displays security reports in the group security dashboard'
do
Page
::
Main
::
Menu
.
perform
(
&
:go_to_groups
)
Page
::
Dashboard
::
Groups
.
perform
do
|
page
|
# rubocop:disable QA/AmbiguousPageObjectName
page
.
click_group
@project
.
group
.
path
Page
::
Dashboard
::
Groups
.
perform
do
|
groups
|
groups
.
click_group
@project
.
group
.
path
end
Page
::
Group
::
Menu
.
perform
(
&
:click_group_security_link
)
...
...
@@ -144,8 +144,8 @@ module QA
it
'displays the Dependency List'
do
Page
::
Project
::
Menu
.
perform
(
&
:click_on_dependency_list
)
EE
::
Page
::
Project
::
Secure
::
DependencyList
.
perform
do
|
page
|
# rubocop:disable QA/AmbiguousPageObjectName
expect
(
page
).
to
have_dependency_count_of
number_of_dependencies_in_fixture
EE
::
Page
::
Project
::
Secure
::
DependencyList
.
perform
do
|
dependency_list
|
expect
(
dependency_list
).
to
have_dependency_count_of
number_of_dependencies_in_fixture
end
end
end
...
...
This diff is collapsed.
Click to expand it.
qa/qa/tools/revoke_all_personal_access_tokens.rb
View file @
5d43c09d
...
...
@@ -32,9 +32,9 @@ module QA
token_name
=
'api-test-token'
Page
::
Profile
::
PersonalAccessTokens
.
perform
do
|
page
|
# rubocop:disable QA/AmbiguousPageObjectName
while
page
.
has_token_row_for_name?
(
token_name
)
page
.
revoke_first_token_with_name
(
token_name
)
Page
::
Profile
::
PersonalAccessTokens
.
perform
do
|
tokens_page
|
while
tokens_
page
.
has_token_row_for_name?
(
token_name
)
tokens_
page
.
revoke_first_token_with_name
(
token_name
)
print
"
\e
[32m.
\e
[0m"
end
end
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment