Apply reviewer feedback

- Remove unneeded method
- Rename variable

app/services/boards/base_items_list_service.rb

@@ -13,11 +13,11 @@ module Boards
 
     # rubocop: disable CodeReuse/ActiveRecord
     def metadata
-      issues = item_model.arel_table
+      issuables = item_model.arel_table
       keys = metadata_fields.keys
       # TODO: eliminate need for SQL literal fragment
       columns = Arel.sql(metadata_fields.values_at(*keys).join(', '))
-      results = item_model.where(id: items.select(issues[:id])).pluck(columns)
+      results = item_model.where(id: items.select(issuables[:id])).pluck(columns)
 
       Hash[keys.zip(results.flatten)]
     end

app/services/boards/issues/list_service.rb

@@ -9,18 +9,6 @@ module Boards
         IssuesFinder.valid_params
       end
 
-      # rubocop: disable CodeReuse/ActiveRecord
-      def metadata
-        issues = Issue.arel_table
-        keys = metadata_fields.keys
-        # TODO: eliminate need for SQL literal fragment
-        columns = Arel.sql(metadata_fields.values_at(*keys).join(', '))
-        results = Issue.where(id: items.select(issues[:id])).pluck(columns)
-
-        Hash[keys.zip(results.flatten)]
-      end
-      # rubocop: enable CodeReuse/ActiveRecord
-
       private
 
       def ordered_items

ee/spec/requests/api/graphql/boards/epic_lists_query_spec.rb

@@ -12,8 +12,6 @@ RSpec.describe 'get list of epic boards' do
   let_it_be(:list2) { create(:epic_list, epic_board: board, list_type: :closed) }
   let_it_be(:list3) { create(:epic_list, epic_board: board, list_type: :backlog) }
 
-  let_it_be(:some_epics) { create_list(:epic, 2, group: group) }
-
   def pagination_query(params = {})
     graphql_query_for(:group, { full_path: group.full_path },
       <<~BOARDS
@@ -82,13 +80,14 @@ RSpec.describe 'get list of epic boards' do
       end
 
       it 'returns the correct values for count' do
+        create_list(:epic, 2, group: group) # epics in backlog, the list which is returned first
+
         post_graphql(pagination_query, current_user: current_user)
 
         assert_field_value('epicsCount', [2, 0, 0])
       end
     end
   end
-  end
 
   def assert_field_value(field, expected_value)
     expect(graphql_dig_at(graphql_data, 'group', 'epicBoard', 'lists', 'nodes', field)).to eq(expected_value)