Commit 5ffdcd9a authored by Peter Leitzen's avatar Peter Leitzen

Merge branch 'update-large-table-spec' into 'master'

Fix duplicate spec in update large table spec

See merge request gitlab-org/gitlab!28787
parents f730919d 77c66674
...@@ -397,6 +397,5 @@ RSpec/RepeatedExample: ...@@ -397,6 +397,5 @@ RSpec/RepeatedExample:
- 'spec/helpers/users_helper_spec.rb' - 'spec/helpers/users_helper_spec.rb'
- 'spec/lib/gitlab/closing_issue_extractor_spec.rb' - 'spec/lib/gitlab/closing_issue_extractor_spec.rb'
- 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb' - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb'
- 'spec/rubocop/cop/migration/update_large_table_spec.rb'
- 'spec/services/notification_service_spec.rb' - 'spec/services/notification_service_spec.rb'
- 'spec/services/web_hook_service_spec.rb' - 'spec/services/web_hook_service_spec.rb'
---
title: Update duplicate specs in update large table spec
merge_request: 28787
author: Rajendra Kadam
type: added
...@@ -76,14 +76,14 @@ describe RuboCop::Cop::Migration::UpdateLargeTable do ...@@ -76,14 +76,14 @@ describe RuboCop::Cop::Migration::UpdateLargeTable do
expect(cop.offenses).to be_empty expect(cop.offenses).to be_empty
end end
it 'registers no offense for update_column_in_batches' do it 'registers no offense for rename_column_concurrently' do
inspect_source("rename_column_concurrently :#{table}, :column, default: true") inspect_source("rename_column_concurrently :#{table}, :column, default: true")
expect(cop.offenses).to be_empty expect(cop.offenses).to be_empty
end end
it 'registers no offense for update_column_in_batches' do it 'registers no offense for update_column_concurrently' do
inspect_source("add_column_with_default :#{table}, :column, default: true") inspect_source("update_column_concurrently :#{table}, :column, default: true")
expect(cop.offenses).to be_empty expect(cop.offenses).to be_empty
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment