Merge branch 'ld-return-note-when-params-blank' into 'master'

Prevent Notes::UpdateService from updating a note when no params passed

See merge request gitlab-org/gitlab!23936

app/services/notes/update_service.rb

@@ -3,7 +3,7 @@
 module Notes
   class UpdateService < BaseService
     def execute(note)
-      return note unless note.editable?
+      return note unless note.editable? && params.present?
 
       old_mentioned_users = note.mentioned_users(current_user).to_a
 

spec/services/notes/update_service_spec.rb

@@ -30,6 +30,12 @@ describe Notes::UpdateService do
       @note.reload
     end
 
+    it 'does not update the note when params is blank' do
+      Timecop.freeze(1.day.from_now) do
+        expect { update_note({}) }.not_to change { note.reload.updated_at }
+      end
+    end
+
     context 'suggestions' do
       it 'refreshes note suggestions' do
         markdown = <<-MARKDOWN.strip_heredoc