Merge branch '264790-bs4-optimization-issuable-header' into 'master'

Remove duplicated BS display properties from Issuables

See merge request gitlab-org/gitlab!45177

app/views/shared/issuable/_close_reopen_button.html.haml

@@ -7,11 +7,11 @@
 
 - if is_current_user && !issuable.is_a?(MergeRequest)
   - if can_update
-    %button{ class: "d-none d-sm-none d-md-block btn btn-grouped btn-close js-btn-issue-action #{issuable_button_visibility(issuable, true)} #{(add_blocked_class ? 'btn-issue-blocked' : '')}",
+    %button{ class: "d-none d-md-block btn btn-grouped btn-close js-btn-issue-action #{issuable_button_visibility(issuable, true)} #{(add_blocked_class ? 'btn-issue-blocked' : '')}",
              data: { remote: 'true', endpoint: close_issuable_path(issuable), qa_selector: 'close_issue_button' } }
       = _("Close %{display_issuable_type}") % { display_issuable_type: display_issuable_type }
   - if can_reopen
-    %button{ class: "d-none d-sm-none d-md-block btn btn-grouped btn-reopen js-btn-issue-action #{issuable_button_visibility(issuable, false)}",
+    %button{ class: "d-none d-md-block btn btn-grouped btn-reopen js-btn-issue-action #{issuable_button_visibility(issuable, false)}",
              data: { remote: 'true', endpoint: reopen_issuable_path(issuable), qa_selector: 'reopen_issue_button' } }
       = _("Reopen %{display_issuable_type}") % { display_issuable_type: display_issuable_type }
 - else
@@ -22,4 +22,4 @@
       = render 'shared/issuable/close_reopen_report_toggle', issuable: issuable, warn_before_close: add_blocked_class
   - else
     = link_to _('Report abuse'), new_abuse_report_path(user_id: issuable.author.id, ref_url: issuable_url(issuable)),
-              class: 'd-none d-sm-none d-md-block btn btn-grouped btn-close-color', title: _('Report abuse')
+              class: 'd-none d-md-block btn btn-grouped btn-close-color', title: _('Report abuse')

app/views/shared/issuable/_close_reopen_report_toggle.html.haml

 - display_issuable_type = issuable_display_type(issuable)
 - button_action = issuable.closed? ? 'reopen' : 'close'
 - display_button_action = button_action.capitalize
-- button_responsive_class = 'd-none d-sm-none d-md-block'
+- button_responsive_class = 'd-none d-md-block'
 - button_class = "#{button_responsive_class} btn btn-grouped js-issuable-close-button js-btn-issue-action issuable-close-button"
 - toggle_class = "#{button_responsive_class} btn btn-nr dropdown-toggle js-issuable-close-toggle"
 - add_blocked_class = false

changelogs/unreleased/264790-bs4-optimization-issuable-header.yml

+---
+title: Remove duplicated BS display properties from Issuables
+merge_request: 45177
+author: Takuya Noguchi
+type: other