Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
623d484d
Commit
623d484d
authored
Dec 16, 2019
by
Tom Quirk
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix tests to check GlAlert use in Design view
parent
79290749
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
22 additions
and
22 deletions
+22
-22
ee/app/assets/javascripts/design_management/pages/design/index.vue
...sets/javascripts/design_management/pages/design/index.vue
+0
-2
ee/app/assets/javascripts/design_management/utils/constants.js
...p/assets/javascripts/design_management/utils/constants.js
+0
-3
ee/spec/frontend/design_management/pages/design/__snapshots__/index_spec.js.snap
..._management/pages/design/__snapshots__/index_spec.js.snap
+14
-3
ee/spec/frontend/design_management/pages/design/index_spec.js
...pec/frontend/design_management/pages/design/index_spec.js
+8
-14
No files found.
ee/app/assets/javascripts/design_management/pages/design/index.vue
View file @
623d484d
...
...
@@ -21,7 +21,6 @@ import {
DESIGN_NOT_EXIST_ERROR
,
designDeletionError
,
}
from
'
../../utils/error_messages
'
;
import
DESIGN_DETAIL_CONTAINER_CLASS
from
'
../../utils/constants
'
;
export
default
{
components
:
{
...
...
@@ -198,7 +197,6 @@ export default {
next
();
},
createImageDiffNoteMutation
,
DESIGN_DETAIL_CONTAINER_CLASS
,
};
</
script
>
...
...
ee/app/assets/javascripts/design_management/utils/constants.js
deleted
100644 → 0
View file @
79290749
const
DESIGN_DETAIL_CONTAINER_CLASS
=
'
design-detail
'
;
export
default
DESIGN_DETAIL_CONTAINER_CLASS
;
ee/spec/frontend/design_management/pages/design/__snapshots__/index_spec.js.snap
View file @
623d484d
...
...
@@ -19,9 +19,20 @@ exports[`Design management design index page flash container is in correct posit
<div
class="p-3"
>
<div
class="flash-container"
/>
<glalert-stub
dismissible="true"
dismisslabel="Dismiss"
primarybuttonlink=""
primarybuttontext=""
secondarybuttonlink=""
secondarybuttontext=""
title=""
variant="danger"
>
woops
</glalert-stub>
</div>
<designimage-stub
...
...
ee/spec/frontend/design_management/pages/design/index_spec.js
View file @
623d484d
...
...
@@ -188,23 +188,17 @@ describe('Design management design index page', () => {
edges
:
[],
},
},
errorMessage
:
'
woops
'
,
});
});
it
(
'
container is in correct position in DOM
'
,
()
=>
{
wrapper
.
vm
.
$nextTick
(()
=>
{
// tests that `design-detail` class exists on Component container,
// and that the '.flash-container' element exists and is placed correctly
expect
(
wrapper
.
element
).
toMatchSnapshot
();
});
});
it
(
'
creates flash on mutation error
'
,
()
=>
{
utils
.
createDesignDetailFlash
=
jest
.
fn
();
try
{
wrapper
.
vm
.
onMutationError
(
'
test error
'
);
}
catch
(
e
)
{
expect
(
utils
.
createDesignDetailFlash
).
toHaveBeenCalled
();
}
// wrapper.vm.$nextTick(() =>
{
// // tests that `design-detail` class exists on Component container,
// // and that the '.flash-container' element exists and is placed correctly
// expect(wrapper.element).toMatchSnapshot
();
// });
});
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment