Merge branch '299489-over-10-of-graphql-descriptions-are-missing-fix-periods' into 'master'

Fix missing periods in GraphQL descriptions

See merge request gitlab-org/gitlab!60442

.rubocop_manual_todo.yml

@@ -13,20 +13,14 @@
 # WIP See https://gitlab.com/gitlab-org/gitlab/-/issues/322903
 Graphql/Descriptions:
   Exclude:
-    - 'app/graphql/types/access_level_enum.rb'
     - 'app/graphql/types/base_enum.rb'
-    - 'app/graphql/types/ci/pipeline_config_source_enum.rb'
-    - 'app/graphql/types/ci/pipeline_status_enum.rb'
     - 'app/graphql/types/container_expiration_policy_cadence_enum.rb'
     - 'app/graphql/types/container_expiration_policy_keep_enum.rb'
     - 'app/graphql/types/container_expiration_policy_older_than_enum.rb'
-    - 'app/graphql/types/notes/position_type_enum.rb'
     - 'app/graphql/types/packages/package_type_enum.rb'
     - 'app/graphql/types/snippets/blob_action_enum.rb'
     - 'app/graphql/types/snippets/type_enum.rb'
     - 'app/graphql/types/snippets/visibility_scopes_enum.rb'
-    - 'app/graphql/types/todo_action_enum.rb'
-    - 'app/graphql/types/tree/type_enum.rb'
     - 'ee/app/graphql/ee/types/list_limit_metric_enum.rb'
     - 'ee/app/graphql/types/alert_management/payload_alert_field_name_enum.rb'
     - 'ee/app/graphql/types/epic_state_enum.rb'

app/graphql/types/access_level_enum.rb

@@ -5,12 +5,12 @@ module Types
     graphql_name 'AccessLevelEnum'
     description 'Access level to a resource'
 
-    value 'NO_ACCESS', value: Gitlab::Access::NO_ACCESS, description: 'No access'
-    value 'MINIMAL_ACCESS', value: Gitlab::Access::MINIMAL_ACCESS, description: 'Minimal access'
-    value 'GUEST', value: Gitlab::Access::GUEST, description: 'Guest access'
-    value 'REPORTER', value: Gitlab::Access::REPORTER, description: 'Reporter access'
-    value 'DEVELOPER', value: Gitlab::Access::DEVELOPER, description: 'Developer access'
-    value 'MAINTAINER', value: Gitlab::Access::MAINTAINER, description: 'Maintainer access'
-    value 'OWNER', value: Gitlab::Access::OWNER, description: 'Owner access'
+    value 'NO_ACCESS', value: Gitlab::Access::NO_ACCESS, description: 'No access.'
+    value 'MINIMAL_ACCESS', value: Gitlab::Access::MINIMAL_ACCESS, description: 'Minimal access.'
+    value 'GUEST', value: Gitlab::Access::GUEST, description: 'Guest access.'
+    value 'REPORTER', value: Gitlab::Access::REPORTER, description: 'Reporter access.'
+    value 'DEVELOPER', value: Gitlab::Access::DEVELOPER, description: 'Developer access.'
+    value 'MAINTAINER', value: Gitlab::Access::MAINTAINER, description: 'Maintainer access.'
+    value 'OWNER', value: Gitlab::Access::OWNER, description: 'Owner access.'
   end
 end

app/graphql/types/alert_management/status_enum.rb

@@ -7,7 +7,7 @@ module Types
       description 'Alert status values'
 
       ::AlertManagement::Alert.status_names.each do |status|
-        value status.to_s.upcase, value: status, description: ::AlertManagement::Alert::STATUS_DESCRIPTIONS[status]
+        value status.to_s.upcase, value: status, description: "#{::AlertManagement::Alert::STATUS_DESCRIPTIONS[status]}."
       end
     end
   end

app/graphql/types/ci/pipeline_status_enum.rb

@@ -5,7 +5,7 @@ module Types
     class PipelineStatusEnum < BaseEnum
       ::Ci::Pipeline.all_state_names.each do |state_symbol|
         value state_symbol.to_s.upcase,
-              description: ::Ci::Pipeline::STATUSES_DESCRIPTION[state_symbol],
+              description: "#{::Ci::Pipeline::STATUSES_DESCRIPTION[state_symbol]}.",
               value: state_symbol.to_s
       end
     end

app/graphql/types/group_member_relation_enum.rb

@@ -6,7 +6,7 @@ module Types
     description 'Group member relation'
 
     ::GroupMembersFinder::RELATIONS.each do |member_relation|
-      value member_relation.to_s.upcase, value: member_relation, description: ::GroupMembersFinder::RELATIONS_DESCRIPTIONS[member_relation]
+      value member_relation.to_s.upcase, value: member_relation, description: "#{::GroupMembersFinder::RELATIONS_DESCRIPTIONS[member_relation]}."
     end
   end
 end

app/graphql/types/notes/position_type_enum.rb

@@ -6,8 +6,8 @@ module Types
       graphql_name 'DiffPositionType'
       description 'Type of file the position refers to'
 
-      value 'text', description: "A text file"
-      value 'image', description: "An image"
+      value 'text', description: "A text file."
+      value 'image', description: "An image."
     end
   end
 end

app/graphql/types/tree/type_enum.rb

@@ -6,9 +6,9 @@ module Types
       graphql_name 'EntryType'
       description 'Type of a tree entry'
 
-      value 'tree', description: 'Directory tree type', value: :tree
-      value 'blob', description: 'File tree type', value: :blob
-      value 'commit', description: 'Commit tree type', value: :commit
+      value 'tree', description: 'Directory tree type.', value: :tree
+      value 'blob', description: 'File tree type.', value: :blob
+      value 'commit', description: 'Commit tree type.', value: :commit
     end
   end
 end