Update group cluster API

- Expose fields managed and enabled where missing
- Update tests to use the new fields
- Update handbook to mention the fields

doc/api/group_clusters.md

@@ -21,7 +21,7 @@ GET /groups/:id/clusters
 Parameters:
 
 | Attribute | Type           | Required | Description                                                                   |
-| --------- | ---- | -------- | ----------- |
+| --------- | -------------- | -------- | ----------------------------------------------------------------------------- |
 | `id`      | integer/string | yes      | The ID or [URL-encoded path of the group](README.md#namespaced-path-encoding) |
 
 Example request:
@@ -39,6 +39,8 @@ Example response:
     "name":"cluster-1",
     "domain":"example.com",
     "created_at":"2019-01-02T20:18:12.563Z",
+    "managed": true,
+    "enabled": true,
     "provider_type":"user",
     "platform_type":"kubernetes",
     "environment_scope":"*",
@@ -88,7 +90,7 @@ GET /groups/:id/clusters/:cluster_id
 Parameters:
 
 | Attribute    | Type           | Required | Description                                                                   |
-| --------- | ---- | -------- | ----------- |
+| ------------ | -------------- | -------- | ----------------------------------------------------------------------------- |
 | `id`         | integer/string | yes      | The ID or [URL-encoded path of the group](README.md#namespaced-path-encoding) |
 | `cluster_id` | integer        | yes      | The ID of the cluster                                                         |
 
@@ -106,6 +108,8 @@ Example response:
   "name":"cluster-1",
   "domain":"example.com",
   "created_at":"2019-01-02T20:18:12.563Z",
+  "managed": true,
+  "enabled": true,
   "provider_type":"user",
   "platform_type":"kubernetes",
   "environment_scope":"*",
@@ -155,7 +159,7 @@ POST /groups/:id/clusters/user
 Parameters:
 
 | Attribute                                            | Type           | Required | Description                                                                                         |
-| --------- | ---- | -------- | ----------- |
+| ---------------------------------------------------- | -------------- | -------- | --------------------------------------------------------------------------------------------------- |
 | `id`                                                 | integer/string | yes      | The ID or [URL-encoded path of the group](README.md#namespaced-path-encoding)                       |
 | `name`                                               | string         | yes      | The name of the cluster                                                                             |
 | `domain`                                             | string         | no       | The [base domain](../user/group/clusters/index.md#base-domain) of the cluster                       |
@@ -184,6 +188,8 @@ Example response:
   "id":24,
   "name":"cluster-5",
   "created_at":"2019-01-03T21:53:40.610Z",
+  "managed": true,
+  "enabled": true,
   "provider_type":"user",
   "platform_type":"kubernetes",
   "environment_scope":"*",
@@ -224,12 +230,14 @@ PUT /groups/:id/clusters/:cluster_id
 Parameters:
 
 | Attribute                                 | Type           | Required | Description                                                                                         |
-| --------- | ---- | -------- | ----------- |
+| ----------------------------------------- | -------------- | -------- | --------------------------------------------------------------------------------------------------- |
 | `id`                                      | integer/string | yes      | The ID or [URL-encoded path of the group](README.md#namespaced-path-encoding)                       |
 | `cluster_id`                              | integer        | yes      | The ID of the cluster                                                                               |
 | `name`                                    | string         | no       | The name of the cluster                                                                             |
 | `domain`                                  | string         | no       | The [base domain](../user/group/clusters/index.md#base-domain) of the cluster                       |
 | `management_project_id`                   | integer        | no       | The ID of the [management project](../user/clusters/management_project.md) for the cluster          |
+| `enabled`                                 | boolean        | no       | Determines if cluster is active or not, defaults to true                                            |
+| `managed`                                 | boolean        | no       | Determines if GitLab will manage namespaces and service accounts for this cluster, defaults to true |
 | `platform_kubernetes_attributes[api_url]` | string         | no       | The URL to access the Kubernetes API                                                                |
 | `platform_kubernetes_attributes[token]`   | string         | no       | The token to authenticate against Kubernetes                                                        |
 | `platform_kubernetes_attributes[ca_cert]` | string         | no       | TLS certificate. Required if API is using a self-signed TLS certificate.                            |
@@ -256,6 +264,8 @@ Example response:
   "name":"new-cluster-name",
   "domain":"new-domain.com",
   "created_at":"2019-01-03T21:53:40.610Z",
+  "managed": true,
+  "enabled": true,
   "provider_type":"user",
   "platform_type":"kubernetes",
   "environment_scope":"*",
@@ -305,7 +315,7 @@ DELETE /groups/:id/clusters/:cluster_id
 Parameters:
 
 | Attribute    | Type           | Required | Description                                                                   |
-| --------- | ---- | -------- | ----------- |
+| ------------ | -------------- | -------- | ----------------------------------------------------------------------------- |
 | `id`         | integer/string | yes      | The ID or [URL-encoded path of the group](README.md#namespaced-path-encoding) |
 | `cluster_id` | integer        | yes      | The ID of the cluster                                                         |
 

lib/api/group_clusters.rb

@@ -75,10 +75,12 @@ module API
       params do
         requires :cluster_id, type: Integer, desc: 'The cluster ID'
         optional :name, type: String, desc: 'Cluster name'
+        optional :enabled, type: Boolean, default: true, desc: 'Determines if cluster is active or not, defaults to true'
         optional :domain, type: String, desc: 'Cluster base domain'
         optional :environment_scope, type: String, desc: 'The associated environment to the cluster'
         optional :namespace_per_environment, default: true, type: Boolean, desc: 'Deploy each environment to a separate Kubernetes namespace'
         optional :management_project_id, type: Integer, desc: 'The ID of the management project'
+        optional :managed, type: Boolean, default: true, desc: 'Determines if GitLab will manage namespaces and service accounts for this cluster, defaults to true'
         optional :platform_kubernetes_attributes, type: Hash, desc: %q(Platform Kubernetes data) do
           optional :api_url, type: String, desc: 'URL to access the Kubernetes API'
           optional :token, type: String, desc: 'Token to authenticate against Kubernetes'

spec/requests/api/group_clusters_spec.rb

@@ -89,6 +89,8 @@ RSpec.describe API::GroupClusters do
         expect(json_response['environment_scope']).to eq('*')
         expect(json_response['cluster_type']).to eq('group_type')
         expect(json_response['domain']).to eq('example.com')
+        expect(json_response['enabled']).to be_truthy
+        expect(json_response['managed']).to be_truthy
       end
 
       it 'returns group information' do
@@ -172,6 +174,7 @@ RSpec.describe API::GroupClusters do
         name: 'test-cluster',
         domain: 'domain.example.com',
         managed: false,
+        enabled: false,
         namespace_per_environment: false,
         platform_kubernetes_attributes: platform_kubernetes_attributes,
         management_project_id: management_project_id
@@ -206,6 +209,7 @@ RSpec.describe API::GroupClusters do
           expect(cluster_result.name).to eq('test-cluster')
           expect(cluster_result.domain).to eq('domain.example.com')
           expect(cluster_result.managed).to be_falsy
+          expect(cluster_result.enabled).to be_falsy
           expect(cluster_result.management_project_id).to eq management_project_id
           expect(cluster_result.namespace_per_environment).to eq(false)
           expect(platform_kubernetes.rbac?).to be_truthy
@@ -342,7 +346,9 @@ RSpec.describe API::GroupClusters do
       {
         domain: domain,
         platform_kubernetes_attributes: platform_kubernetes_attributes,
-        management_project_id: management_project_id
+        management_project_id: management_project_id,
+        managed: false,
+        enabled: false
       }
     end
 
@@ -381,6 +387,8 @@ RSpec.describe API::GroupClusters do
         it 'updates cluster attributes' do
           expect(cluster.domain).to eq('new-domain.com')
           expect(cluster.management_project).to eq(management_project)
+          expect(cluster.managed).to be_falsy
+          expect(cluster.enabled).to be_falsy
         end
       end
 
@@ -394,6 +402,8 @@ RSpec.describe API::GroupClusters do
         it 'does not update cluster attributes' do
           expect(cluster.domain).to eq('old-domain.com')
           expect(cluster.management_project).to be_nil
+          expect(cluster.managed).to be_truthy
+          expect(cluster.enabled).to be_truthy
         end
 
         it 'returns validation errors' do