Split a Review Apps CI rule into two dedicated rules

In-order to prevent `review-performance` from running, a condition was
set in `.review:rules:mr-and-schedule-auto-if-frontend-manual-otherwise`
in `.gitlab/ci/rules.gitlab-ci.yml` file, but this also prevented
`review-deploy` from running as `review-deploy` also extended
`.review:rules:mr-and-schedule-auto-if-frontend-manual-otherwise`.

Since the `dast` jobs are set to `needs: ["review-deploy"]`, the CI
config was invalid. Unfortunately, when for scheduled pipeline, there's
no error logged or raised.
Signed-off-by: Rémy Coutable <remy@rymai.me>

.gitlab/ci/review.gitlab-ci.yml

@@ -53,7 +53,7 @@ review-build-cng:
 review-deploy:
   extends:
     - .review-workflow-base
-    - .review:rules:mr-and-schedule-auto-if-frontend-manual-otherwise
+    - .review:rules:review-deploy
   stage: review
   dependencies: []
   resource_group: "review/${CI_COMMIT_REF_NAME}"
@@ -172,7 +172,7 @@ review-qa-all:
 review-performance:
   extends:
     - .default-retry
-    - .review:rules:mr-and-schedule-auto-if-frontend-manual-otherwise
+    - .review:rules:review-performance
   image:
     name: sitespeedio/sitespeed.io:6.3.1
     entrypoint: [""]

.gitlab/ci/rules.gitlab-ci.yml

@@ -669,7 +669,23 @@
       allow_failure: true
     - <<: *if-dot-com-gitlab-org-schedule
 
-.review:rules:mr-and-schedule-auto-if-frontend-manual-otherwise:
+.review:rules:review-deploy:
+  rules:
+    - <<: *if-not-ee
+      when: never
+    - <<: *if-dot-com-gitlab-org-merge-request
+      changes: *ci-review-patterns
+    - <<: *if-dot-com-gitlab-org-merge-request
+      changes: *frontend-patterns
+      allow_failure: true
+    - <<: *if-dot-com-gitlab-org-merge-request
+      changes: *code-qa-patterns
+      when: manual
+      allow_failure: true
+    - <<: *if-dot-com-gitlab-org-schedule
+      allow_failure: true
+
+.review:rules:review-performance:
   rules:
     - if: '$DAST_RUN == "true"' # Skip this job when DAST is run
       when: never