Merge branch 'issue#325836-fix-empty-line-after-let-it-be-services-groups' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/services/groups

See merge request gitlab-org/gitlab!58423

.rubocop_manual_todo.yml

@@ -1003,10 +1003,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/services/feature_flags/enable_service_spec.rb
     - spec/services/feature_flags/update_service_spec.rb
     - spec/services/git/branch_push_service_spec.rb
-    - spec/services/groups/auto_devops_service_spec.rb
-    - spec/services/groups/group_links/update_service_spec.rb
-    - spec/services/groups/transfer_service_spec.rb
-    - spec/services/groups/update_shared_runners_service_spec.rb
     - spec/services/import/bitbucket_server_service_spec.rb
     - spec/services/incident_management/incidents/create_service_spec.rb
     - spec/services/incident_management/pager_duty/create_incident_issue_service_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-services-groups.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses in spec/services/groups
+merge_request: 58423
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/services/groups/auto_devops_service_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 RSpec.describe Groups::AutoDevopsService, '#execute' do
   let_it_be(:group) { create(:group) }
   let_it_be(:user) { create(:user) }
+
   let(:group_params) { { auto_devops_enabled: '0' } }
   let(:service) { described_class.new(group, user, group_params) }
 

spec/services/groups/group_links/update_service_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe Groups::GroupLinks::UpdateService, '#execute' do
   let_it_be(:group) { create(:group, :private) }
   let_it_be(:shared_group) { create(:group, :private) }
   let_it_be(:project) { create(:project, group: shared_group) }
+
   let(:group_member_user) { create(:user) }
   let!(:link) { create(:group_group_link, shared_group: shared_group, shared_with_group: group) }
 

spec/services/groups/transfer_service_spec.rb

@@ -5,12 +5,14 @@ require 'spec_helper'
 RSpec.describe Groups::TransferService do
   let_it_be(:user) { create(:user) }
   let_it_be(:new_parent_group) { create(:group, :public) }
+
   let!(:group_member) { create(:group_member, :owner, group: group, user: user) }
   let(:transfer_service) { described_class.new(group, user) }
 
   context 'handling packages' do
     let_it_be(:group) { create(:group, :public) }
     let_it_be(:new_group) { create(:group, :public) }
+
     let(:project) { create(:project, :public, namespace: group) }
 
     before do
@@ -272,6 +274,7 @@ RSpec.describe Groups::TransferService do
 
         context 'with a group integration' do
           let_it_be(:instance_integration) { create(:slack_service, :instance, webhook: 'http://project.slack.com') }
+
           let(:new_created_integration) { Service.find_by(group: group) }
 
           context 'with an inherited integration' do

spec/services/groups/update_shared_runners_service_spec.rb

@@ -59,6 +59,7 @@ RSpec.describe Groups::UpdateSharedRunnersService do
 
       context 'disable shared Runners' do
         let_it_be(:group) { create(:group) }
+
         let(:params) { { shared_runners_setting: 'disabled_and_unoverridable' } }
 
         it 'receives correct method and succeeds' do