Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
70800237
Commit
70800237
authored
Dec 13, 2021
by
Kev
Committed by
David O'Regan
Dec 13, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix GraphQL/OrderedArguments offense (Part 2/6)
parent
52492f2c
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
12 additions
and
15 deletions
+12
-15
.rubocop_todo/graphql/ordered_arguments.yml
.rubocop_todo/graphql/ordered_arguments.yml
+0
-3
app/graphql/resolvers/base_issues_resolver.rb
app/graphql/resolvers/base_issues_resolver.rb
+3
-3
app/graphql/resolvers/design_management/designs_resolver.rb
app/graphql/resolvers/design_management/designs_resolver.rb
+5
-5
app/graphql/resolvers/design_management/version/design_at_version_resolver.rb
...s/design_management/version/design_at_version_resolver.rb
+4
-4
No files found.
.rubocop_todo/graphql/ordered_arguments.yml
View file @
70800237
...
...
@@ -3,9 +3,6 @@ GraphQL/OrderedArguments:
Exclude
:
-
app/graphql/mutations/jira_import/start.rb
-
app/graphql/mutations/merge_requests/accept.rb
-
app/graphql/resolvers/base_issues_resolver.rb
-
app/graphql/resolvers/design_management/designs_resolver.rb
-
app/graphql/resolvers/design_management/version/design_at_version_resolver.rb
-
app/graphql/resolvers/design_management/version/designs_at_version_resolver.rb
-
app/graphql/resolvers/design_management/version_in_collection_resolver.rb
-
app/graphql/resolvers/group_milestones_resolver.rb
...
...
app/graphql/resolvers/base_issues_resolver.rb
View file @
70800237
...
...
@@ -4,13 +4,13 @@ module Resolvers
class
BaseIssuesResolver
<
BaseResolver
prepend
IssueResolverArguments
argument
:state
,
Types
::
IssuableStateEnum
,
required:
false
,
description:
'Current state of this issue.'
argument
:sort
,
Types
::
IssueSortEnum
,
description:
'Sort issues by this criteria.'
,
required:
false
,
default_value: :created_desc
argument
:state
,
Types
::
IssuableStateEnum
,
required:
false
,
description:
'Current state of this issue.'
type
Types
::
IssueType
.
connection_type
,
null:
true
...
...
app/graphql/resolvers/design_management/designs_resolver.rb
View file @
70800237
...
...
@@ -8,16 +8,16 @@ module Resolvers
type
::
Types
::
DesignManagement
::
DesignType
.
connection_type
,
null:
true
argument
:
ids
,
[
DesignID
]
,
argument
:
at_version
,
VersionID
,
required:
false
,
description:
'Filters designs by their ID.'
description:
'Filters designs to only those that existed at the version. '
\
'If argument is omitted or nil then all designs will reflect the latest version'
argument
:filenames
,
[
GraphQL
::
Types
::
String
],
required:
false
,
description:
'Filters designs by their filename.'
argument
:
at_version
,
VersionID
,
argument
:
ids
,
[
DesignID
]
,
required:
false
,
description:
'Filters designs to only those that existed at the version. '
\
'If argument is omitted or nil then all designs will reflect the latest version'
description:
'Filters designs by their ID.'
def
self
.
single
::
Resolvers
::
DesignManagement
::
DesignResolver
...
...
app/graphql/resolvers/design_management/version/design_at_version_resolver.rb
View file @
70800237
...
...
@@ -16,16 +16,16 @@ module Resolvers
authorize
:read_design
argument
:id
,
DesignAtVersionID
,
required:
false
,
as: :design_at_version_id
,
description:
'ID of the DesignAtVersion.'
argument
:design_id
,
DesignID
,
required:
false
,
description:
'ID of a specific design.'
argument
:filename
,
GraphQL
::
Types
::
String
,
required:
false
,
description:
'Filename of a specific design.'
argument
:id
,
DesignAtVersionID
,
required:
false
,
as: :design_at_version_id
,
description:
'ID of the DesignAtVersion.'
def
self
.
single
self
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment