Better path handling in specs

lib/backup/manager.rb

@@ -264,7 +264,7 @@ module Backup
     def create_attributes
       attrs = {
         key: remote_target,
-        body: File.open(tar_file),
+        body: File.open("#{backup_path}/#{tar_file}"),
         multipart_chunk_size: Gitlab.config.backup.upload.multipart_chunk_size,
         encryption: Gitlab.config.backup.upload.encryption,
         encryption_key: Gitlab.config.backup.upload.encryption_key,

spec/lib/backup/manager_spec.rb

@@ -329,10 +329,8 @@ describe Backup::Manager do
           .with(hash_including(key: backup_filename, public: false))
           .and_return(true)
 
-        Dir.chdir(Gitlab.config.backup.path) do
         subject.upload
       end
-      end
 
       it 'adds the DIRECTORY environment variable if present' do
         stub_env('DIRECTORY', 'daily')
@@ -341,11 +339,9 @@ describe Backup::Manager do
           .with(hash_including(key: "daily/#{backup_filename}", public: false))
           .and_return(true)
 
-        Dir.chdir(Gitlab.config.backup.path) do
         subject.upload
       end
     end
-    end
 
     context 'with Google provider' do
       before do
@@ -373,10 +369,8 @@ describe Backup::Manager do
           .with(hash_excluding(public: false))
           .and_return(true)
 
-        Dir.chdir(Gitlab.config.backup.path) do
         subject.upload
       end
     end
   end
-  end
 end