Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
76ff2656
Commit
76ff2656
authored
Feb 04, 2020
by
Robert May
Committed by
Marcia Ramos
Feb 04, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add a new section on iteration to Code Review docs
parent
f97a383f
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
0 deletions
+6
-0
doc/development/code_review.md
doc/development/code_review.md
+6
-0
No files found.
doc/development/code_review.md
View file @
76ff2656
...
@@ -347,6 +347,12 @@ reviewee.
...
@@ -347,6 +347,12 @@ reviewee.
of the contributed code. It's usually a good idea to ask another maintainer or
of the contributed code. It's usually a good idea to ask another maintainer or
reviewer before doing it, but have the courage to do it when you believe it is
reviewer before doing it, but have the courage to do it when you believe it is
important.
important.
-
In the interest of
[
Iteration
](
https://about.gitlab.com/handbook/values/#iteration
)
,
if, as a reviewer, your suggestions are non-blocking changes or personal preference
(not a documented or agreed requirement), consider approving the merge request
before passing it back to the author. This allows them to implement your suggestions
if they agree, or allows them to pass it onto the
maintainer for review straight away. This can help reduce our overall time-to-merge.
-
There is a difference in doing things right and doing things right now.
-
There is a difference in doing things right and doing things right now.
Ideally, we should do the former, but in the real world we need the latter as
Ideally, we should do the former, but in the real world we need the latter as
well. A good example is a security fix which should be released as soon as
well. A good example is a security fix which should be released as soon as
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment