Merge branch 'issue#325836-fix-empty-line-after-let-it-be-lib-gitlab' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab

See merge request gitlab-org/gitlab!58314

.rubocop_manual_todo.yml

@@ -1122,16 +1122,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/lib/gitlab/repository_size_error_message_spec.rb
     - spec/lib/gitlab/search_results_spec.rb
     - spec/lib/gitlab/shell_spec.rb
-    - spec/lib/gitlab/slash_commands/presenters/issue_comment_spec.rb
-    - spec/lib/gitlab/slash_commands/presenters/issue_move_spec.rb
-    - spec/lib/gitlab/snippet_search_results_spec.rb
-    - spec/lib/gitlab/sourcegraph_spec.rb
-    - spec/lib/gitlab/template/finders/repo_template_finders_spec.rb
-    - spec/lib/gitlab/tree_summary_spec.rb
-    - spec/lib/gitlab/url_builder_spec.rb
-    - spec/lib/gitlab/usage/metrics/aggregates/sources/postgres_hll_spec.rb
-    - spec/lib/gitlab/utils/usage_data_spec.rb
-    - spec/lib/gitlab/workhorse_spec.rb
     - spec/mailers/emails/projects_spec.rb
     - spec/mailers/emails/releases_spec.rb
     - spec/mailers/emails/service_desk_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-lib-gitlab.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab
+merge_request: 58314
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/gitlab/slash_commands/presenters/issue_comment_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Gitlab::SlashCommands::Presenters::IssueComment do
   let_it_be(:project) { create(:project) }
   let_it_be(:issue) { create(:issue, project: project) }
   let_it_be(:note) { create(:note, project: project, noteable: issue) }
+
   let(:author) { note.author }
 
   describe '#present' do

spec/lib/gitlab/slash_commands/presenters/issue_move_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe Gitlab::SlashCommands::Presenters::IssueMove do
   let_it_be(:project, reload: true) { create(:project) }
   let_it_be(:other_project) { create(:project) }
   let_it_be(:old_issue, reload: true) { create(:issue, project: project) }
+
   let(:new_issue) { Issues::MoveService.new(project, user).execute(old_issue, other_project) }
   let(:attachment) { subject[:attachments].first }
 

spec/lib/gitlab/snippet_search_results_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Gitlab::SnippetSearchResults do
   include SearchHelpers
 
   let_it_be(:snippet) { create(:snippet, content: 'foo', file_name: 'foo') }
+
   let(:results) { described_class.new(snippet.author, 'foo') }
 
   describe '#snippet_titles_count' do

spec/lib/gitlab/sourcegraph_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::Sourcegraph do
   let_it_be(:user) { create(:user) }
+
   let(:feature_scope) { true }
 
   before do

spec/lib/gitlab/template/finders/repo_template_finders_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::Template::Finders::RepoTemplateFinder do
   let_it_be(:project) { create(:project, :repository) }
+
   let(:categories) { { 'HTML' => 'html' } }
 
   subject(:finder) { described_class.new(project, 'files/', '.html', categories) }

spec/lib/gitlab/tree_summary_spec.rb

@@ -226,6 +226,7 @@ RSpec.describe Gitlab::TreeSummary do
   describe 'References in commit messages' do
     let_it_be(:project) { create(:project, :empty_repo) }
     let_it_be(:issue) { create(:issue, project: project) }
+
     let(:entries) { summary.summarize.first }
     let(:entry) { entries.find { |entry| entry[:file_name] == 'issue.txt' } }
 

spec/lib/gitlab/url_builder_spec.rb

@@ -92,6 +92,7 @@ RSpec.describe Gitlab::UrlBuilder do
     context 'when passing a Snippet' do
       let_it_be(:personal_snippet) { create(:personal_snippet, :repository) }
       let_it_be(:project_snippet)  { create(:project_snippet, :repository) }
+
       let(:blob)                   { snippet.blobs.first }
       let(:ref)                    { blob.repository.root_ref }
 

spec/lib/gitlab/usage/metrics/aggregates/sources/postgres_hll_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe Gitlab::Usage::Metrics::Aggregates::Sources::PostgresHll, :clean_
   let_it_be(:end_date) { Date.current }
   let_it_be(:recorded_at) { Time.current }
   let_it_be(:time_period) { { created_at: (start_date..end_date) } }
+
   let(:metric_1) { 'metric_1' }
   let(:metric_2) { 'metric_2' }
   let(:metric_names) { [metric_1, metric_2] }

spec/lib/gitlab/utils/usage_data_spec.rb

@@ -187,6 +187,7 @@ RSpec.describe Gitlab::Utils::UsageData do
 
   describe '#histogram' do
     let_it_be(:projects) { create_list(:project, 3) }
+
     let(:project1) { projects.first }
     let(:project2) { projects.second }
     let(:project3) { projects.third }

spec/lib/gitlab/workhorse_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::Workhorse do
   let_it_be(:project) { create(:project, :repository) }
+
   let(:repository) { project.repository }
 
   def decode_workhorse_header(array)