Commit 7b6dd7b3 authored by Rémy Coutable's avatar Rémy Coutable

Resolve conflicts

Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
parent baf94bf1
# This configuration was generated by # This configuration was generated by
# `rubocop --auto-gen-config --exclude-limit 0` # `rubocop --auto-gen-config --exclude-limit 0`
<<<<<<< HEAD
# on 2017-01-11 09:34:02 +0000 using RuboCop version 0.46.0. # on 2017-01-11 09:34:02 +0000 using RuboCop version 0.46.0.
=======
# on 2017-01-11 09:38:25 +0000 using RuboCop version 0.46.0.
>>>>>>> ce/master
# The point is for the user to remove these configuration records # The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base. # one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new # Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again. # versions of RuboCop, may require this file to be generated again.
<<<<<<< HEAD
# Offense count: 28 # Offense count: 28
=======
# Offense count: 27
>>>>>>> ce/master
# Configuration parameters: Include. # Configuration parameters: Include.
# Include: **/Gemfile, **/gems.rb # Include: **/Gemfile, **/gems.rb
Bundler/OrderedGems: Bundler/OrderedGems:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 181 # Offense count: 181
Lint/AmbiguousRegexpLiteral: Lint/AmbiguousRegexpLiteral:
Enabled: false Enabled: false
# Offense count: 60 # Offense count: 60
=======
# Offense count: 175
Lint/AmbiguousRegexpLiteral:
Enabled: false
# Offense count: 53
>>>>>>> ce/master
# Configuration parameters: AllowSafeAssignment. # Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition: Lint/AssignmentInCondition:
Enabled: false Enabled: false
...@@ -41,15 +25,11 @@ Lint/AssignmentInCondition: ...@@ -41,15 +25,11 @@ Lint/AssignmentInCondition:
Lint/EmptyWhen: Lint/EmptyWhen:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 22 # Offense count: 22
=======
# Offense count: 20
>>>>>>> ce/master
Lint/HandleExceptions: Lint/HandleExceptions:
Enabled: false Enabled: false
# Offense count: 1 # Offense count: 2
Lint/Loop: Lint/Loop:
Enabled: false Enabled: false
...@@ -62,50 +42,29 @@ Lint/ShadowingOuterLocalVariable: ...@@ -62,50 +42,29 @@ Lint/ShadowingOuterLocalVariable:
Lint/UnifiedInteger: Lint/UnifiedInteger:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 22 # Offense count: 22
=======
# Offense count: 21
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
Lint/UnneededSplatExpansion: Lint/UnneededSplatExpansion:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 95 # Offense count: 95
=======
# Offense count: 82
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
Lint/UnusedBlockArgument: Lint/UnusedBlockArgument:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 186 # Offense count: 186
=======
# Offense count: 173
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods. # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
Lint/UnusedMethodArgument: Lint/UnusedMethodArgument:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 112 # Offense count: 112
# Configuration parameters: CountComments. # Configuration parameters: CountComments.
Metrics/BlockLength: Metrics/BlockLength:
Max: 303 Max: 303
# Offense count: 4 # Offense count: 4
=======
# Offense count: 93
# Configuration parameters: CountComments.
Metrics/BlockLength:
Max: 288
# Offense count: 3
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
Performance/RedundantBlockCall: Performance/RedundantBlockCall:
Enabled: false Enabled: false
...@@ -115,11 +74,7 @@ Performance/RedundantBlockCall: ...@@ -115,11 +74,7 @@ Performance/RedundantBlockCall:
Performance/RedundantMatch: Performance/RedundantMatch:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 36 # Offense count: 36
=======
# Offense count: 32
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: MaxKeyValuePairs. # Configuration parameters: MaxKeyValuePairs.
Performance/RedundantMerge: Performance/RedundantMerge:
...@@ -129,11 +84,7 @@ Performance/RedundantMerge: ...@@ -129,11 +84,7 @@ Performance/RedundantMerge:
RSpec/BeEql: RSpec/BeEql:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 26 # Offense count: 26
=======
# Offense count: 15
>>>>>>> ce/master
# Configuration parameters: CustomIncludeMethods. # Configuration parameters: CustomIncludeMethods.
RSpec/EmptyExampleGroup: RSpec/EmptyExampleGroup:
Enabled: false Enabled: false
...@@ -142,27 +93,18 @@ RSpec/EmptyExampleGroup: ...@@ -142,27 +93,18 @@ RSpec/EmptyExampleGroup:
RSpec/ExpectActual: RSpec/ExpectActual:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 83 # Offense count: 83
=======
# Offense count: 58
>>>>>>> ce/master
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: implicit, each, example # SupportedStyles: implicit, each, example
RSpec/HookArgument: RSpec/HookArgument:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 25 # Offense count: 25
=======
# Offense count: 12
>>>>>>> ce/master
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: is_expected, should # SupportedStyles: is_expected, should
RSpec/ImplicitExpect: RSpec/ImplicitExpect:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 265 # Offense count: 265
RSpec/LeadingSubject: RSpec/LeadingSubject:
Enabled: false Enabled: false
...@@ -176,27 +118,11 @@ RSpec/MessageChain: ...@@ -176,27 +118,11 @@ RSpec/MessageChain:
Enabled: false Enabled: false
# Offense count: 518 # Offense count: 518
=======
# Offense count: 237
RSpec/LeadingSubject:
Enabled: false
# Offense count: 253
RSpec/LetSetup:
Enabled: false
# Offense count: 13
RSpec/MessageChain:
Enabled: false
# Offense count: 479
>>>>>>> ce/master
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: have_received, receive # SupportedStyles: have_received, receive
RSpec/MessageSpies: RSpec/MessageSpies:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 3278 # Offense count: 3278
RSpec/MultipleExpectations: RSpec/MultipleExpectations:
Max: 37 Max: 37
...@@ -206,26 +132,11 @@ RSpec/NamedSubject: ...@@ -206,26 +132,11 @@ RSpec/NamedSubject:
Enabled: false Enabled: false
# Offense count: 2111 # Offense count: 2111
=======
# Offense count: 3036
RSpec/MultipleExpectations:
Max: 37
# Offense count: 2133
RSpec/NamedSubject:
Enabled: false
# Offense count: 1974
>>>>>>> ce/master
# Configuration parameters: MaxNesting. # Configuration parameters: MaxNesting.
RSpec/NestedGroups: RSpec/NestedGroups:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 36 # Offense count: 36
=======
# Offense count: 32
>>>>>>> ce/master
RSpec/RepeatedDescription: RSpec/RepeatedDescription:
Enabled: false Enabled: false
...@@ -233,49 +144,29 @@ RSpec/RepeatedDescription: ...@@ -233,49 +144,29 @@ RSpec/RepeatedDescription:
RSpec/SingleArgumentMessageChain: RSpec/SingleArgumentMessageChain:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 137 # Offense count: 137
RSpec/SubjectStub: RSpec/SubjectStub:
Enabled: false Enabled: false
# Offense count: 113 # Offense count: 113
=======
# Offense count: 133
RSpec/SubjectStub:
Enabled: false
# Offense count: 104
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: Whitelist. # Configuration parameters: Whitelist.
# Whitelist: find_by_sql # Whitelist: find_by_sql
Rails/DynamicFindBy: Rails/DynamicFindBy:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 1010 # Offense count: 1010
=======
# Offense count: 932
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: Include. # Configuration parameters: Include.
# Include: spec/**/*, test/**/* # Include: spec/**/*, test/**/*
Rails/HttpPositionalArguments: Rails/HttpPositionalArguments:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 59 # Offense count: 59
Rails/OutputSafety: Rails/OutputSafety:
Enabled: false Enabled: false
# Offense count: 203 # Offense count: 203
=======
# Offense count: 55
Rails/OutputSafety:
Enabled: false
# Offense count: 182
>>>>>>> ce/master
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: strict, flexible # SupportedStyles: strict, flexible
Rails/TimeZone: Rails/TimeZone:
...@@ -288,54 +179,34 @@ Rails/TimeZone: ...@@ -288,54 +179,34 @@ Rails/TimeZone:
Rails/Validation: Rails/Validation:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 9 # Offense count: 9
=======
# Offense count: 8
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AutoCorrect. # Configuration parameters: AutoCorrect.
Security/JSONLoad: Security/JSONLoad:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 365 # Offense count: 365
=======
# Offense count: 346
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: with_first_parameter, with_fixed_indentation # SupportedStyles: with_first_parameter, with_fixed_indentation
Style/AlignParameters: Style/AlignParameters:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 29 # Offense count: 29
=======
# Offense count: 27
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: always, conditionals # SupportedStyles: always, conditionals
Style/AndOr: Style/AndOr:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 53 # Offense count: 53
=======
# Offense count: 54
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: percent_q, bare_percent # SupportedStyles: percent_q, bare_percent
Style/BarePercentLiterals: Style/BarePercentLiterals:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 387 # Offense count: 387
=======
# Offense count: 358
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: braces, no_braces, context_dependent # SupportedStyles: braces, no_braces, context_dependent
...@@ -346,11 +217,7 @@ Style/BracesAroundHashParameters: ...@@ -346,11 +217,7 @@ Style/BracesAroundHashParameters:
Style/CaseEquality: Style/CaseEquality:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 41 # Offense count: 41
=======
# Offense count: 37
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/ColonMethodCall: Style/ColonMethodCall:
Enabled: false Enabled: false
...@@ -362,50 +229,30 @@ Style/ColonMethodCall: ...@@ -362,50 +229,30 @@ Style/ColonMethodCall:
Style/CommentAnnotation: Style/CommentAnnotation:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 33 # Offense count: 33
=======
# Offense count: 29
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly. # Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
# SupportedStyles: assign_to_condition, assign_inside_condition # SupportedStyles: assign_to_condition, assign_inside_condition
Style/ConditionalAssignment: Style/ConditionalAssignment:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 1279 # Offense count: 1279
=======
# Offense count: 1210
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: leading, trailing # SupportedStyles: leading, trailing
Style/DotPosition: Style/DotPosition:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 19 # Offense count: 19
Style/DoubleNegation: Style/DoubleNegation:
Enabled: false Enabled: false
# Offense count: 10 # Offense count: 10
=======
# Offense count: 18
Style/DoubleNegation:
Enabled: false
# Offense count: 7
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/EachWithObject: Style/EachWithObject:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 25 # Offense count: 25
=======
# Offense count: 24
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: empty, nil, both # SupportedStyles: empty, nil, both
...@@ -417,22 +264,14 @@ Style/EmptyElse: ...@@ -417,22 +264,14 @@ Style/EmptyElse:
Style/EmptyLiteral: Style/EmptyLiteral:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 64 # Offense count: 64
=======
# Offense count: 57
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, expanded # SupportedStyles: compact, expanded
Style/EmptyMethod: Style/EmptyMethod:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 159 # Offense count: 159
=======
# Offense count: 147
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Style/ExtraSpacing: Style/ExtraSpacing:
...@@ -444,11 +283,7 @@ Style/ExtraSpacing: ...@@ -444,11 +283,7 @@ Style/ExtraSpacing:
Style/FormatString: Style/FormatString:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 287 # Offense count: 287
=======
# Offense count: 238
>>>>>>> ce/master
# Configuration parameters: MinBodyLength. # Configuration parameters: MinBodyLength.
Style/GuardClause: Style/GuardClause:
Enabled: false Enabled: false
...@@ -457,43 +292,27 @@ Style/GuardClause: ...@@ -457,43 +292,27 @@ Style/GuardClause:
Style/IfInsideElse: Style/IfInsideElse:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 186 # Offense count: 186
=======
# Offense count: 173
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: MaxLineLength. # Configuration parameters: MaxLineLength.
Style/IfUnlessModifier: Style/IfUnlessModifier:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 61 # Offense count: 61
=======
# Offense count: 55
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_brackets # SupportedStyles: special_inside_parentheses, consistent, align_brackets
Style/IndentArray: Style/IndentArray:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 128 # Offense count: 128
=======
# Offense count: 101
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_braces # SupportedStyles: special_inside_parentheses, consistent, align_braces
Style/IndentHash: Style/IndentHash:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 49 # Offense count: 49
=======
# Offense count: 41
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: line_count_dependent, lambda, literal # SupportedStyles: line_count_dependent, lambda, literal
...@@ -519,11 +338,7 @@ Style/MethodMissing: ...@@ -519,11 +338,7 @@ Style/MethodMissing:
Style/MultilineIfModifier: Style/MultilineIfModifier:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 200 # Offense count: 200
=======
# Offense count: 179
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/MutableConstant: Style/MutableConstant:
Enabled: false Enabled: false
...@@ -547,31 +362,19 @@ Style/Next: ...@@ -547,31 +362,19 @@ Style/Next:
Style/NumericLiteralPrefix: Style/NumericLiteralPrefix:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 24 # Offense count: 24
=======
# Offense count: 19
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles. # Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
# SupportedStyles: predicate, comparison # SupportedStyles: predicate, comparison
Style/NumericPredicate: Style/NumericPredicate:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 35 # Offense count: 35
=======
# Offense count: 34
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/ParallelAssignment: Style/ParallelAssignment:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 427 # Offense count: 427
=======
# Offense count: 417
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters. # Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters: Style/PercentLiteralDelimiters:
...@@ -589,11 +392,7 @@ Style/PercentQLiterals: ...@@ -589,11 +392,7 @@ Style/PercentQLiterals:
Style/PerlBackrefs: Style/PerlBackrefs:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 69 # Offense count: 69
=======
# Offense count: 64
>>>>>>> ce/master
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist. # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
# NamePrefix: is_, has_, have_ # NamePrefix: is_, has_, have_
# NamePrefixBlacklist: is_, has_, have_ # NamePrefixBlacklist: is_, has_, have_
...@@ -601,11 +400,7 @@ Style/PerlBackrefs: ...@@ -601,11 +400,7 @@ Style/PerlBackrefs:
Style/PredicateName: Style/PredicateName:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 36 # Offense count: 36
=======
# Offense count: 33
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: short, verbose # SupportedStyles: short, verbose
...@@ -617,11 +412,7 @@ Style/PreferredHashMethods: ...@@ -617,11 +412,7 @@ Style/PreferredHashMethods:
Style/Proc: Style/Proc:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 52 # Offense count: 52
=======
# Offense count: 50
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, exploded # SupportedStyles: compact, exploded
...@@ -649,40 +440,24 @@ Style/RedundantFreeze: ...@@ -649,40 +440,24 @@ Style/RedundantFreeze:
Style/RedundantReturn: Style/RedundantReturn:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 462 # Offense count: 462
=======
# Offense count: 359
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/RedundantSelf: Style/RedundantSelf:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 109 # Offense count: 109
=======
# Offense count: 105
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes. # Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
# SupportedStyles: slashes, percent_r, mixed # SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral: Style/RegexpLiteral:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 23 # Offense count: 23
=======
# Offense count: 19
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/RescueModifier: Style/RescueModifier:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 8 # Offense count: 8
=======
# Offense count: 7
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/SelfAssignment: Style/SelfAssignment:
Enabled: false Enabled: false
...@@ -699,72 +474,44 @@ Style/SingleLineBlockParams: ...@@ -699,72 +474,44 @@ Style/SingleLineBlockParams:
Style/SingleLineMethods: Style/SingleLineMethods:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 166 # Offense count: 166
=======
# Offense count: 138
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: space, no_space # SupportedStyles: space, no_space
Style/SpaceBeforeBlockBraces: Style/SpaceBeforeBlockBraces:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 9 # Offense count: 9
=======
# Offense count: 8
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment. # Configuration parameters: AllowForAlignment.
Style/SpaceBeforeFirstArg: Style/SpaceBeforeFirstArg:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 44 # Offense count: 44
=======
# Offense count: 37
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: require_no_space, require_space # SupportedStyles: require_no_space, require_space
Style/SpaceInLambdaLiteral: Style/SpaceInLambdaLiteral:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 180 # Offense count: 180
=======
# Offense count: 174
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space # SupportedStyles: space, no_space
Style/SpaceInsideBlockBraces: Style/SpaceInsideBlockBraces:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 118 # Offense count: 118
=======
# Offense count: 115
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/SpaceInsideBrackets: Style/SpaceInsideBrackets:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 86 # Offense count: 86
=======
# Offense count: 77
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/SpaceInsideParens: Style/SpaceInsideParens:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 6 # Offense count: 6
=======
# Offense count: 4
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/SpaceInsidePercentLiteralDelimiters: Style/SpaceInsidePercentLiteralDelimiters:
Enabled: false Enabled: false
...@@ -776,22 +523,14 @@ Style/SpaceInsidePercentLiteralDelimiters: ...@@ -776,22 +523,14 @@ Style/SpaceInsidePercentLiteralDelimiters:
Style/SpecialGlobalVars: Style/SpecialGlobalVars:
EnforcedStyle: use_perl_names EnforcedStyle: use_perl_names
<<<<<<< HEAD
# Offense count: 29 # Offense count: 29
=======
# Offense count: 25
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: single_quotes, double_quotes # SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation: Style/StringLiteralsInInterpolation:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 56 # Offense count: 56
=======
# Offense count: 54
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods. # Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method # IgnoredMethods: respond_to, define_method
...@@ -812,11 +551,7 @@ Style/TernaryParentheses: ...@@ -812,11 +551,7 @@ Style/TernaryParentheses:
Style/TrailingCommaInArguments: Style/TrailingCommaInArguments:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 166 # Offense count: 166
=======
# Offense count: 150
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles. # Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma # SupportedStyles: comma, consistent_comma, no_comma
...@@ -829,20 +564,12 @@ Style/TrailingCommaInLiteral: ...@@ -829,20 +564,12 @@ Style/TrailingCommaInLiteral:
Style/TrailingUnderscoreVariable: Style/TrailingUnderscoreVariable:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 86 # Offense count: 86
=======
# Offense count: 67
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/TrailingWhitespace: Style/TrailingWhitespace:
Enabled: false Enabled: false
<<<<<<< HEAD
# Offense count: 4 # Offense count: 4
=======
# Offense count: 3
>>>>>>> ce/master
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist. # Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym # Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
......
...@@ -284,14 +284,10 @@ GEM ...@@ -284,14 +284,10 @@ GEM
diff-lcs (~> 1.1) diff-lcs (~> 1.1)
mime-types (>= 1.16, < 3) mime-types (>= 1.16, < 3)
posix-spawn (~> 0.3) posix-spawn (~> 0.3)
<<<<<<< HEAD
gitlab-license (1.0.0) gitlab-license (1.0.0)
gitlab-markup (1.5.0)
=======
gitlab-markup (1.5.1) gitlab-markup (1.5.1)
gitlab-turbolinks-classic (2.5.6) gitlab-turbolinks-classic (2.5.6)
coffee-rails coffee-rails
>>>>>>> ce/master
gitlab_omniauth-ldap (1.2.1) gitlab_omniauth-ldap (1.2.1)
net-ldap (~> 0.9) net-ldap (~> 0.9)
omniauth (~> 1.0) omniauth (~> 1.0)
...@@ -923,13 +919,9 @@ DEPENDENCIES ...@@ -923,13 +919,9 @@ DEPENDENCIES
github-linguist (~> 4.7.0) github-linguist (~> 4.7.0)
gitlab-elasticsearch-git (~> 1.0.1) gitlab-elasticsearch-git (~> 1.0.1)
gitlab-flowdock-git-hook (~> 1.0.1) gitlab-flowdock-git-hook (~> 1.0.1)
<<<<<<< HEAD
gitlab-license (~> 1.0) gitlab-license (~> 1.0)
gitlab-markup (~> 1.5.0)
=======
gitlab-markup (~> 1.5.1) gitlab-markup (~> 1.5.1)
gitlab-turbolinks-classic (~> 2.5, >= 2.5.6) gitlab-turbolinks-classic (~> 2.5, >= 2.5.6)
>>>>>>> ce/master
gitlab_omniauth-ldap (~> 1.2.1) gitlab_omniauth-ldap (~> 1.2.1)
gollum-lib (~> 4.2) gollum-lib (~> 4.2)
gollum-rugged_adapter (~> 0.4.2) gollum-rugged_adapter (~> 0.4.2)
...@@ -1012,11 +1004,7 @@ DEPENDENCIES ...@@ -1012,11 +1004,7 @@ DEPENDENCIES
rqrcode-rails3 (~> 0.1.7) rqrcode-rails3 (~> 0.1.7)
rspec-rails (~> 3.5.0) rspec-rails (~> 3.5.0)
rspec-retry (~> 0.4.5) rspec-retry (~> 0.4.5)
<<<<<<< HEAD
rubocop (~> 0.43.0)
=======
rubocop (~> 0.46.0) rubocop (~> 0.46.0)
>>>>>>> ce/master
rubocop-rspec (~> 1.9.1) rubocop-rspec (~> 1.9.1)
ruby-fogbugz (~> 0.2.1) ruby-fogbugz (~> 0.2.1)
ruby-prof (~> 0.16.2) ruby-prof (~> 0.16.2)
......
...@@ -69,7 +69,24 @@ module Gitlab ...@@ -69,7 +69,24 @@ module Gitlab
@ldap_user ||= Gitlab::LDAP::Person.find_by_dn(user.ldap_identity.extern_uid, adapter) @ldap_user ||= Gitlab::LDAP::Person.find_by_dn(user.ldap_identity.extern_uid, adapter)
end end
<<<<<<< HEAD def block_user(user, reason)
user.ldap_block
Gitlab::AppLogger.info(
"LDAP account \"#{user.ldap_identity.extern_uid}\" #{reason}, " \
"blocking Gitlab user \"#{user.name}\" (#{user.email})"
)
end
def unblock_user(user, reason)
user.activate
Gitlab::AppLogger.info(
"LDAP account \"#{user.ldap_identity.extern_uid}\" #{reason}, " \
"unblocking Gitlab user \"#{user.name}\" (#{user.email})"
)
end
def update_user def update_user
update_email update_email
update_ssh_keys if sync_ssh_keys? update_ssh_keys if sync_ssh_keys?
...@@ -151,24 +168,6 @@ module Gitlab ...@@ -151,24 +168,6 @@ module Gitlab
def logger def logger
Rails.logger Rails.logger
=======
def block_user(user, reason)
user.ldap_block
Gitlab::AppLogger.info(
"LDAP account \"#{user.ldap_identity.extern_uid}\" #{reason}, " \
"blocking Gitlab user \"#{user.name}\" (#{user.email})"
)
end
def unblock_user(user, reason)
user.activate
Gitlab::AppLogger.info(
"LDAP account \"#{user.ldap_identity.extern_uid}\" #{reason}, " \
"unblocking Gitlab user \"#{user.name}\" (#{user.email})"
)
>>>>>>> ce/master
end end
end end
end end
......
...@@ -14,13 +14,9 @@ describe Gitlab::LDAP::Access, lib: true do ...@@ -14,13 +14,9 @@ describe Gitlab::LDAP::Access, lib: true do
it { is_expected.to be_falsey } it { is_expected.to be_falsey }
<<<<<<< HEAD
it 'blocks user in GitLab' do it 'blocks user in GitLab' do
=======
it 'should block user in GitLab' do
expect(access).to receive(:block_user).with(user, 'does not exist anymore') expect(access).to receive(:block_user).with(user, 'does not exist anymore')
>>>>>>> ce/master
access.allowed? access.allowed?
end end
end end
...@@ -116,7 +112,48 @@ describe Gitlab::LDAP::Access, lib: true do ...@@ -116,7 +112,48 @@ describe Gitlab::LDAP::Access, lib: true do
end end
end end
<<<<<<< HEAD describe '#block_user' do
before do
user.activate
allow(Gitlab::AppLogger).to receive(:info)
access.block_user user, 'reason'
end
it 'blocks the user' do
expect(user).to be_blocked
expect(user).to be_ldap_blocked
end
it 'logs the reason' do
expect(Gitlab::AppLogger).to have_received(:info).with(
"LDAP account \"123456\" reason, " \
"blocking Gitlab user \"#{user.name}\" (#{user.email})"
)
end
end
describe '#unblock_user' do
before do
user.ldap_block
allow(Gitlab::AppLogger).to receive(:info)
access.unblock_user user, 'reason'
end
it 'activates the user' do
expect(user).not_to be_blocked
expect(user).not_to be_ldap_blocked
end
it 'logs the reason' do
Gitlab::AppLogger.info(
"LDAP account \"123456\" reason, " \
"unblocking Gitlab user \"#{user.name}\" (#{user.email})"
)
end
end
describe '#update_user' do describe '#update_user' do
subject { access.update_user } subject { access.update_user }
let(:entry) do let(:entry) do
...@@ -266,47 +303,6 @@ describe Gitlab::LDAP::Access, lib: true do ...@@ -266,47 +303,6 @@ describe Gitlab::LDAP::Access, lib: true do
it "updates the email if the user email is different" do it "updates the email if the user email is different" do
entry['mail'] = ["new_email@example.com"] entry['mail'] = ["new_email@example.com"]
expect{ access.update_email }.to change(user, :email) expect{ access.update_email }.to change(user, :email)
=======
describe '#block_user' do
before do
user.activate
allow(Gitlab::AppLogger).to receive(:info)
access.block_user user, 'reason'
end
it 'blocks the user' do
expect(user).to be_blocked
expect(user).to be_ldap_blocked
end
it 'logs the reason' do
expect(Gitlab::AppLogger).to have_received(:info).with(
"LDAP account \"123456\" reason, " \
"blocking Gitlab user \"#{user.name}\" (#{user.email})"
)
end
end
describe '#unblock_user' do
before do
user.ldap_block
allow(Gitlab::AppLogger).to receive(:info)
access.unblock_user user, 'reason'
end
it 'activates the user' do
expect(user).not_to be_blocked
expect(user).not_to be_ldap_blocked
end
it 'logs the reason' do
Gitlab::AppLogger.info(
"LDAP account \"123456\" reason, " \
"unblocking Gitlab user \"#{user.name}\" (#{user.email})"
)
>>>>>>> ce/master
end end
end end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment