Rename set_all to bulk_update

This changes the name of Gitlab::Database::SetAll to
Gitlab::Database::BulkUpdate, which is a more accurate name.

app/models/concerns/relative_positioning.rb

@@ -111,7 +111,7 @@ module RelativePositioning
             { relative_position: desired_pos.clamp(lower_bound, upper_bound) }
           end
 
-          ::Gitlab::Database::SetAll.set_all([:relative_position], mapping, &:model_class)
+          ::Gitlab::Database::BulkUpdate.execute([:relative_position], mapping, &:model_class)
         end
       end
 

doc/development/database/setting_multiple_values.md

@@ -33,7 +33,7 @@ down to ARel - the `UpdateManager` just does not support `update from`, so this
 is not expressible.
 
 The good news: We supply an abstraction to help you generate these kinds of
-updates, called `Gitlab::Database::SetAll`. This constructs queries such as the
+updates, called `Gitlab::Database::BulkUpdate`. This constructs queries such as the
 above, and uses binding parameters to avoid SQL injection.
 
 ## Usage
@@ -51,7 +51,7 @@ issue_a = Issue.find(..)
 issue_b = Issue.find(..)
 
 # Issues a single query:
-::Gitlab::Database::SetAll.set_all(%i[title weight], {
+::Gitlab::Database::BulkUpdate.execute(%i[title weight], {
   issue_a => { title: 'Very difficult issue', weight: 8 },
   issue_b => { title: 'Very easy issue', weight: 1 }
 })
@@ -69,7 +69,7 @@ issue_b = Issue.find(..)
 merge_request = MergeRequest.find(..)
 
 # Issues two queries
-::Gitlab::Database::SetAll.set_all(%i[title], {
+::Gitlab::Database::BulkUpdate.execute(%i[title], {
   issue_a => { title: 'A' },
   issue_b => { title: 'B' },
   merge_request => { title: 'B' }
@@ -90,7 +90,7 @@ objects = Foo.from_union([
 mapping = objects.to_h { |obj| [obj, bazzes[obj.id] }
     
 # Issues at most 2 queries
-::Gitlab::Database::SetAll.set_all(%i[baz], mapping) do |obj|
+::Gitlab::Database::BulkUpdate.execute(%i[baz], mapping) do |obj|
   obj.object_type.constantize
 end
 ```

lib/gitlab/database/set_all.rb → lib/gitlab/database/bulk_update.rb

@@ -23,13 +23,13 @@ module Gitlab
     #    issue_b => { title: 'That title', relative_position: 173 }
     #  }
     #
-    #  ::Gitlab::Database::SetAll.set_all(%i[title relative_position], mapping)
+    #  ::Gitlab::Database::BulkUpdate.execute(%i[title relative_position], mapping)
     #
     # Note that this is a very low level tool, and operates on the raw column
     # values. Enums/state fields must be translated into their underlying
     # representations, for example, and no hooks will be called.
     #
-    module SetAll
+    module BulkUpdate
       LIST_SEPARATOR = ', '
 
       class Setter
@@ -58,13 +58,15 @@ module Gitlab
           raise ArgumentError, 'invalid columns' if columns.blank? || columns.any? { |c| !c.is_a?(Symbol) }
           raise ArgumentError, 'cannot set ID' if columns.include?(:id)
 
-          ([:id] | columns).map do |name|
+          ([:id] | columns).map { |name| column_definition(model, name) }
+        end
+
+        def self.column_definition(model, name)
           definition = model.column_for_attribute(name)
           raise ArgumentError, "Unknown column: #{name}" unless definition.type
 
           definition
         end
-        end
 
         def self.value_mapping(mapping)
           raise ArgumentError, 'invalid mapping' if mapping.blank?
@@ -79,7 +81,7 @@ module Gitlab
 
         def log_name
           strong_memoize(:log_name) do
-            "SetAll #{table_name} #{columns.drop(1).map(&:name)}:#{mapping.size}"
+            "BulkUpdate #{table_name} #{columns.drop(1).map(&:name)}:#{mapping.size}"
           end
         end
 
@@ -152,7 +154,7 @@ module Gitlab
         end
       end
 
-      def self.set_all(columns, mapping, &to_class)
+      def self.execute(columns, mapping, &to_class)
         raise ArgumentError if mapping.blank?
 
         entries_by_class = mapping.group_by { |k, v| block_given? ? to_class.call(k) : k.class }

spec/lib/gitlab/database/set_all_spec.rb → spec/lib/gitlab/database/bulk_update_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Gitlab::Database::SetAll do
+RSpec.describe Gitlab::Database::BulkUpdate do
   describe 'error states' do
     let(:columns) { %i[title] }
 
@@ -19,33 +19,33 @@ RSpec.describe Gitlab::Database::SetAll do
     end
 
     it 'does not raise errors on valid inputs' do
-      expect { described_class.set_all(columns, mapping) }.not_to raise_error
+      expect { described_class.execute(columns, mapping) }.not_to raise_error
     end
 
     it 'expects a non-empty list of column names' do
-      expect { described_class.set_all([], mapping) }.to raise_error(ArgumentError)
+      expect { described_class.execute([], mapping) }.to raise_error(ArgumentError)
     end
 
     it 'expects all columns to be symbols' do
-      expect { described_class.set_all([1], mapping) }.to raise_error(ArgumentError)
+      expect { described_class.execute([1], mapping) }.to raise_error(ArgumentError)
     end
 
     it 'expects all columns to be valid columns on the tables' do
-      expect { described_class.set_all([:foo], mapping) }.to raise_error(ArgumentError)
+      expect { described_class.execute([:foo], mapping) }.to raise_error(ArgumentError)
     end
 
     it 'refuses to set ID' do
-      expect { described_class.set_all([:id], mapping) }.to raise_error(ArgumentError)
+      expect { described_class.execute([:id], mapping) }.to raise_error(ArgumentError)
     end
 
     it 'expects a non-empty mapping' do
-      expect { described_class.set_all(columns, []) }.to raise_error(ArgumentError)
+      expect { described_class.execute(columns, []) }.to raise_error(ArgumentError)
     end
 
     it 'expects all map values to be Hash instances' do
       bad_map = mapping.merge(build(:issue) => 2)
 
-      expect { described_class.set_all(columns, bad_map) }.to raise_error(ArgumentError)
+      expect { described_class.execute(columns, bad_map) }.to raise_error(ArgumentError)
     end
   end
 
@@ -56,7 +56,7 @@ RSpec.describe Gitlab::Database::SetAll do
     end
 
     expect do
-      described_class.set_all(%i[username admin], mapping)
+      described_class.execute(%i[username admin], mapping)
     end.not_to exceed_query_limit(1)
 
     # We have optimistically updated the values
@@ -84,7 +84,7 @@ RSpec.describe Gitlab::Database::SetAll do
     }
 
     expect do
-      described_class.set_all(%i[title], mapping)
+      described_class.execute(%i[title], mapping)
     end.not_to exceed_query_limit(2)
 
     expect([mr_a, i_a, i_b].map { |x| x.reset.title })
@@ -103,7 +103,7 @@ RSpec.describe Gitlab::Database::SetAll do
         i_b  => { title: 'Issue b' }
       }
 
-      described_class.set_all(%i[title], mapping)
+      described_class.execute(%i[title], mapping)
 
       expect([i_a, i_b].map { |x| x.reset.title })
         .to eq(['Issue a', 'Issue b'])

spec/lib/gitlab/relative_positioning/mover_spec.rb

@@ -41,7 +41,7 @@ RSpec.describe RelativePositioning::Mover do
       [issue, { relative_position: pos }]
     end
 
-    ::Gitlab::Database::SetAll.set_all([:relative_position], mapping)
+    ::Gitlab::Database::BulkUpdate.execute([:relative_position], mapping)
   end
 
   def ids_in_position_order