Commit 819b2051 authored by Scott Hampton's avatar Scott Hampton

Remove virtual list from test report

The virtual list component has a bug with
tall rows, causing the scrolling to get messed
up and the report unusable. This is a temporary
fix until we can fix the virtual list component.
parent abc1a9c6
...@@ -2,13 +2,11 @@ ...@@ -2,13 +2,11 @@
import { mapGetters } from 'vuex'; import { mapGetters } from 'vuex';
import { GlTooltipDirective, GlFriendlyWrap, GlIcon } from '@gitlab/ui'; import { GlTooltipDirective, GlFriendlyWrap, GlIcon } from '@gitlab/ui';
import { __ } from '~/locale'; import { __ } from '~/locale';
import SmartVirtualList from '~/vue_shared/components/smart_virtual_list.vue';
export default { export default {
name: 'TestsSuiteTable', name: 'TestsSuiteTable',
components: { components: {
GlIcon, GlIcon,
SmartVirtualList,
GlFriendlyWrap, GlFriendlyWrap,
}, },
directives: { directives: {
...@@ -27,8 +25,6 @@ export default { ...@@ -27,8 +25,6 @@ export default {
return this.getSuiteTests.length > 0; return this.getSuiteTests.length > 0;
}, },
}, },
maxShownRows: 30,
typicalRowHeight: 75,
wrapSymbols: ['::', '#', '.', '_', '-', '/', '\\'], wrapSymbols: ['::', '#', '.', '_', '-', '/', '\\'],
}; };
</script> </script>
...@@ -60,11 +56,6 @@ export default { ...@@ -60,11 +56,6 @@ export default {
</div> </div>
</div> </div>
<smart-virtual-list
:length="getSuiteTests.length"
:remain="$options.maxShownRows"
:size="$options.typicalRowHeight"
>
<div <div
v-for="(testCase, index) in getSuiteTests" v-for="(testCase, index) in getSuiteTests"
:key="index" :key="index"
...@@ -119,7 +110,6 @@ export default { ...@@ -119,7 +110,6 @@ export default {
</div> </div>
</div> </div>
</div> </div>
</smart-virtual-list>
</div> </div>
<div v-else> <div v-else>
......
...@@ -2,13 +2,11 @@ ...@@ -2,13 +2,11 @@
import { mapGetters } from 'vuex'; import { mapGetters } from 'vuex';
import { GlIcon, GlTooltipDirective } from '@gitlab/ui'; import { GlIcon, GlTooltipDirective } from '@gitlab/ui';
import { s__ } from '~/locale'; import { s__ } from '~/locale';
import SmartVirtualList from '~/vue_shared/components/smart_virtual_list.vue';
export default { export default {
name: 'TestsSummaryTable', name: 'TestsSummaryTable',
components: { components: {
GlIcon, GlIcon,
SmartVirtualList,
}, },
directives: { directives: {
GlTooltip: GlTooltipDirective, GlTooltip: GlTooltipDirective,
...@@ -31,8 +29,6 @@ export default { ...@@ -31,8 +29,6 @@ export default {
this.$emit('row-click', index); this.$emit('row-click', index);
}, },
}, },
maxShownRows: 20,
typicalRowHeight: 55,
}; };
</script> </script>
...@@ -69,11 +65,6 @@ export default { ...@@ -69,11 +65,6 @@ export default {
</div> </div>
</div> </div>
<smart-virtual-list
:length="getTestSuites.length"
:remain="$options.maxShownRows"
:size="$options.typicalRowHeight"
>
<div <div
v-for="(testSuite, index) in getTestSuites" v-for="(testSuite, index) in getTestSuites"
:key="index" :key="index"
...@@ -145,7 +136,6 @@ export default { ...@@ -145,7 +136,6 @@ export default {
<div class="table-mobile-content">{{ testSuite.total_count }}</div> <div class="table-mobile-content">{{ testSuite.total_count }}</div>
</div> </div>
</div> </div>
</smart-virtual-list>
</div> </div>
<div v-else> <div v-else>
......
---
title: Remove virtual scroll list from pipeline test report
merge_request: 41935
author:
type: fixed
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment