Fix Admin area user access level radio button labels

In the admin user edit form, access level radio button labels didn't have
the correct 'for' value. Clicking on the label did not select the radio
button. This makes usability a bit nicer since the click area is increased
when the label is clickable.

app/views/admin/users/_access_levels.html.haml

@@ -19,7 +19,7 @@
       - editing_current_user = (current_user == @user)
 
       = f.radio_button :access_level, :regular, disabled: editing_current_user
-      = label_tag :regular, class: 'font-weight-bold' do
+      = f.label :access_level_regular, class: 'font-weight-bold' do
         Regular
       %p.light
         Regular users have access to their groups and projects
@@ -27,7 +27,7 @@
       = render_if_exists 'admin/users/auditor_access_level_radio', f: f, disabled: editing_current_user
 
       = f.radio_button :access_level, :admin, disabled: editing_current_user
-      = label_tag :admin, class: 'font-weight-bold' do
+      = f.label :access_level_admin, class: 'font-weight-bold' do
         Admin
       %p.light
         Administrators have access to all groups, projects and users and can manage all features in this installation

changelogs/unreleased/dblessing-fix-admin-user-radio-labels.yml

+---
+title: Fix admin area user access level radio button labels
+merge_request: 31154
+author:
+type: fixed