Commit 833cb6e9 authored by Filipa Lacerda's avatar Filipa Lacerda

Merge branch 'gt-remove-tooltip-directive-on-project-avatar-image-component' into 'master'

Remove tooltip directive on project avatar image component

Closes #51990

See merge request gitlab-org/gitlab-ce!29631
parents 6e8640a0 8c92afc3
...@@ -17,13 +17,9 @@ ...@@ -17,13 +17,9 @@
import defaultAvatarUrl from 'images/no_avatar.png'; import defaultAvatarUrl from 'images/no_avatar.png';
import { placeholderImage } from '../../../lazy_loader'; import { placeholderImage } from '../../../lazy_loader';
import tooltip from '../../directives/tooltip';
export default { export default {
name: 'ProjectAvatarImage', name: 'ProjectAvatarImage',
directives: {
tooltip,
},
props: { props: {
lazy: { lazy: {
type: Boolean, type: Boolean,
...@@ -50,16 +46,6 @@ export default { ...@@ -50,16 +46,6 @@ export default {
required: false, required: false,
default: 20, default: 20,
}, },
tooltipText: {
type: String,
required: false,
default: '',
},
tooltipPlacement: {
type: String,
required: false,
default: 'top',
},
}, },
computed: { computed: {
// API response sends null when gravatar is disabled and // API response sends null when gravatar is disabled and
...@@ -71,9 +57,6 @@ export default { ...@@ -71,9 +57,6 @@ export default {
resultantSrcAttribute() { resultantSrcAttribute() {
return this.lazy ? placeholderImage : this.sanitizedSource; return this.lazy ? placeholderImage : this.sanitizedSource;
}, },
tooltipContainer() {
return this.tooltipText ? 'body' : null;
},
avatarSizeClass() { avatarSizeClass() {
return `s${this.size}`; return `s${this.size}`;
}, },
...@@ -83,7 +66,6 @@ export default { ...@@ -83,7 +66,6 @@ export default {
<template> <template>
<img <img
v-tooltip
:class="{ :class="{
lazy: lazy, lazy: lazy,
[avatarSizeClass]: true, [avatarSizeClass]: true,
...@@ -94,9 +76,6 @@ export default { ...@@ -94,9 +76,6 @@ export default {
:height="size" :height="size"
:alt="imgAlt" :alt="imgAlt"
:data-src="sanitizedSource" :data-src="sanitizedSource"
:data-container="tooltipContainer"
:data-placement="tooltipPlacement"
:title="tooltipText"
class="avatar" class="avatar"
/> />
</template> </template>
---
title: Remove tooltip directive on project avatar image component
merge_request: 29631
author: George Tsiolis
type: performance
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment