Commit 8507897f authored by GitLab Bot's avatar GitLab Bot

Automatic merge of gitlab-org/gitlab-ce master

parents b537b92f 55da8b27
...@@ -173,6 +173,7 @@ module Projects ...@@ -173,6 +173,7 @@ module Projects
end end
def remove_registry_tags def remove_registry_tags
return true unless Gitlab.config.registry.enabled
return false unless remove_legacy_registry_tags return false unless remove_legacy_registry_tags
project.container_repositories.find_each do |container_repository| project.container_repositories.find_each do |container_repository|
......
---
title: Don't attempt to contact registry if it is disabled
merge_request: 31553
author:
type: fixed
...@@ -241,6 +241,18 @@ describe Projects::DestroyService do ...@@ -241,6 +241,18 @@ describe Projects::DestroyService do
expect(destroy_project(project, user)).to be false expect(destroy_project(project, user)).to be false
end end
end end
context 'when registry is disabled' do
before do
stub_container_registry_config(enabled: false)
end
it 'does not attempting to remove any tags' do
expect(Projects::ContainerRepository::DestroyService).not_to receive(:new)
destroy_project(project, user)
end
end
end end
context 'when there are tags for legacy root repository' do context 'when there are tags for legacy root repository' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment