Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
85151ff6
Commit
85151ff6
authored
Dec 07, 2017
by
Shinya Maeda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Change feature flag to ci_disable_validates_dependencies to enable it as default
parent
c2f68b7a
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
3 deletions
+3
-3
app/models/ci/build.rb
app/models/ci/build.rb
+1
-1
spec/models/ci/build_spec.rb
spec/models/ci/build_spec.rb
+1
-1
spec/services/ci/register_job_service_spec.rb
spec/services/ci/register_job_service_spec.rb
+1
-1
No files found.
app/models/ci/build.rb
View file @
85151ff6
...
@@ -143,7 +143,7 @@ module Ci
...
@@ -143,7 +143,7 @@ module Ci
end
end
before_transition
any
=>
[
:running
]
do
|
build
|
before_transition
any
=>
[
:running
]
do
|
build
|
build
.
validates_dependencies!
if
Feature
.
enabled?
(
'ci
_validates_dependencies'
)
build
.
validates_dependencies!
unless
Feature
.
enabled?
(
'ci_disable
_validates_dependencies'
)
end
end
end
end
...
...
spec/models/ci/build_spec.rb
View file @
85151ff6
...
@@ -1870,7 +1870,7 @@ describe Ci::Build do
...
@@ -1870,7 +1870,7 @@ describe Ci::Build do
describe
'state transition: any => [:running]'
do
describe
'state transition: any => [:running]'
do
before
do
before
do
stub_feature_flags
(
ci_validates_dependencies:
true
)
stub_feature_flags
(
ci_
disable_
validates_dependencies:
true
)
end
end
let
(
:build
)
{
create
(
:ci_build
,
:pending
,
pipeline:
pipeline
,
stage_idx:
1
,
options:
options
)
}
let
(
:build
)
{
create
(
:ci_build
,
:pending
,
pipeline:
pipeline
,
stage_idx:
1
,
options:
options
)
}
...
...
spec/services/ci/register_job_service_spec.rb
View file @
85151ff6
...
@@ -278,7 +278,7 @@ module Ci
...
@@ -278,7 +278,7 @@ module Ci
context
'when "dependencies" keyword is specified'
do
context
'when "dependencies" keyword is specified'
do
before
do
before
do
stub_feature_flags
(
ci_
validates_dependencies:
tru
e
)
stub_feature_flags
(
ci_
disable_validates_dependencies:
fals
e
)
end
end
let!
(
:pre_stage_job
)
{
create
(
:ci_build
,
:success
,
pipeline:
pipeline
,
name:
job_name
,
stage_idx:
0
)
}
let!
(
:pre_stage_job
)
{
create
(
:ci_build
,
:success
,
pipeline:
pipeline
,
name:
job_name
,
stage_idx:
0
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment