Commit 8baad1ca authored by Marc Shaw's avatar Marc Shaw

Merge branch 'lm-remove-ci-validate-job-length-ff' into 'master'

Remove ci validate job length feature flag

See merge request gitlab-org/gitlab!83320
parents e34d7c85 a111c80f
---
name: ci_validate_job_length
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/73599
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/344665
milestone: '14.5'
type: development
group: group::pipeline authoring
default_enabled: true
...@@ -111,9 +111,10 @@ You can't use these keywords as job names: ...@@ -111,9 +111,10 @@ You can't use these keywords as job names:
- `false` - `false`
- `nil` - `nil`
Job names must be 255 characters or less. [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/342800) Job names must be 255 characters or less.
in GitLab 14.5, [with a feature flag](../../administration/feature_flags.md) named `ci_validate_job_length`.
Enabled by default. To disable it, ask an administrator to [disable the feature flag](../../administration/feature_flags.md). > - [Enabled on GitLab.com](https://gitlab.com/gitlab-org/gitlab/-/issues/342800) in GitLab 14.5.
> - [Generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/344665) in GitLab 14.10.[Feature flag <ci_validate_job_length>](https://gitlab.com/gitlab-org/gitlab/-/issues/344665) removed.
Use unique names for your jobs. If multiple jobs have the same name, Use unique names for your jobs. If multiple jobs have the same name,
only one is added to the pipeline, and it's difficult to predict which one is chosen. only one is added to the pipeline, and it's difficult to predict which one is chosen.
......
...@@ -23,7 +23,7 @@ module Gitlab ...@@ -23,7 +23,7 @@ module Gitlab
validates :config, presence: true validates :config, presence: true
validates :name, presence: true validates :name, presence: true
validates :name, type: Symbol validates :name, type: Symbol
validates :name, length: { maximum: 255 }, if: -> { ::Feature.enabled?(:ci_validate_job_length, default_enabled: :yaml) } validates :name, length: { maximum: 255 }
validates :config, disallowed_keys: { validates :config, disallowed_keys: {
in: %i[only except start_in], in: %i[only except start_in],
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment