Adds mirror params to POST #create project endpoint parameters

ee/lib/ee/api/entities.rb

@@ -18,6 +18,11 @@ module EE
         prepended do
           expose :repository_storage, if: ->(_project, options) { options[:current_user].try(:admin?) }
           expose :approvals_before_merge, if: ->(project, _) { project.feature_available?(:merge_request_approvers) }
+          expose :mirror, if: ->(project, _) { project.feature_available?(:repository_mirrors) }
+          expose :mirror_user_id, if: ->(project, _) { project.feature_available?(:repository_mirrors) }
+          expose :mirror_trigger_builds, if: ->(project, _) { project.feature_available?(:repository_mirrors) }
+          expose :only_mirror_protected_branches, if: ->(project, _) { project.feature_available?(:repository_mirrors) }
+          expose :mirror_overwrites_diverged_branches, if: ->(project, _) { project.feature_available?(:repository_mirrors) }
         end
       end
 

ee/lib/ee/api/helpers.rb

@@ -61,6 +61,16 @@ module EE
             ::Gitlab::CurrentSettings.current_application_settings
               .allow_group_owners_to_manage_ldap
       end
+
+      def valid_mirror_user?(mirror_params)
+        return true unless mirror_params[:mirror_user_id].present?
+
+        default_mirror_users.map(&:id).include?(mirror_params[:mirror_user_id].to_i)
+      end
+
+      def default_mirror_users
+        [current_user, user_project.mirror_user].compact.uniq
+      end
     end
   end
 end

ee/spec/requests/api/projects_spec.rb

@@ -4,9 +4,52 @@ describe API::Projects do
   include ExternalAuthorizationServiceHelpers
 
   let(:user) { create(:user) }
-  let(:project) { create(:project, namespace: user.namespace) }
+
+  describe 'POST /projects' do
+    context 'when importing with mirror attributes' do
+      let(:import_url) { generate(:url) }
+      let(:mirror_params) do
+        {
+          name: "Foo",
+          mirror: true,
+          import_url: import_url,
+          mirror_user_id: user.id,
+          mirror_trigger_builds: true
+        }
+      end
+
+      it 'creates new project with pull mirroring setup' do
+        post api('/projects', user), mirror_params
+
+        expect(response).to have_gitlab_http_status(201)
+        expect(Project.first).to have_attributes(
+          mirror: true,
+          import_url: import_url,
+          mirror_user_id: user.id,
+          mirror_trigger_builds: true
+        )
+      end
+
+      it 'creates project without mirror settings when repository mirroring feature is disabled' do
+        stub_licensed_features(repository_mirrors: false)
+
+        expect { post api('/projects', user), mirror_params }
+          .to change { Project.count }.by(1)
+
+        expect(response).to have_gitlab_http_status(201)
+        expect(Project.first).to have_attributes(
+          mirror: false,
+          import_url: import_url,
+          mirror_user_id: nil,
+          mirror_trigger_builds: false
+        )
+      end
+    end
+  end
 
   describe 'PUT /projects/:id' do
+    let(:project) { create(:project, namespace: user.namespace) }
+
     before do
       enable_external_authorization_service_check
     end
@@ -18,6 +61,61 @@ describe API::Projects do
 
       expect(project.reload.external_authorization_classification_label).to eq('new label')
     end
+
+    context 'when updating mirror related attributes' do
+      let(:import_url) { generate(:url) }
+      let(:mirror_params) do
+        {
+          mirror: true,
+          import_url: import_url,
+          mirror_user_id: user.id,
+          mirror_trigger_builds: true,
+          only_mirror_protected_branches: true,
+          mirror_overwrites_diverged_branches: true
+        }
+      end
+
+      it 'updates mirror related attributes' do
+        put(api("/projects/#{project.id}", user), mirror_params)
+
+        expect(response).to have_gitlab_http_status(200)
+        expect(project.reload).to have_attributes(
+          mirror: true,
+          import_url: import_url,
+          mirror_user_id: user.id,
+          mirror_trigger_builds: true,
+          only_mirror_protected_branches: true,
+          mirror_overwrites_diverged_branches: true
+        )
+      end
+
+      it 'reverts to current user when mirror_user_id is invalid' do
+        invalid_mirror_user = create(:user)
+        project.add_developer(invalid_mirror_user)
+        mirror_params[:mirror_user_id] = invalid_mirror_user.id
+
+        put(api("/projects/#{project.id}", user), mirror_params)
+
+        expect(response).to have_gitlab_http_status(200)
+        expect(project.reload).to have_attributes(
+          mirror: true,
+          import_url: import_url,
+          mirror_user_id: user.id,
+          mirror_trigger_builds: true,
+          only_mirror_protected_branches: true,
+          mirror_overwrites_diverged_branches: true
+        )
+      end
+
+      it 'returns 403 when the user does not have access to mirror settings' do
+        developer = create(:user)
+        project.add_developer(developer)
+
+        put(api("/projects/#{project.id}", developer), mirror_params)
+
+        expect(response).to have_gitlab_http_status(:forbidden)
+      end
+    end
   end
 
   describe 'GET /projects' do

lib/api/helpers/projects_helpers.rb

@@ -32,6 +32,9 @@ module API
             optional :repository_storage, type: String, desc: 'Which storage shard the repository is on. Available only to admins'
             optional :approvals_before_merge, type: Integer, desc: 'How many approvers should approve merge request by default'
             optional :external_authorization_classification_label, type: String, desc: 'The classification label for the project'
+            optional :mirror, type: Boolean, desc: 'Enables pull mirroring in a project'
+            optional :mirror_user_id, type: Integer, desc: 'User responsible for all the activity surrounding a pull mirror event'
+            optional :mirror_trigger_builds, type: Boolean, desc: 'Pull mirroring triggers builds'
           end
 
           params :optional_project_params do

lib/api/projects.rb

@@ -140,6 +140,8 @@ module API
       post do
         attrs = declared_params(include_missing: false)
         attrs = translate_params_for_compatibility(attrs)
+        attrs[:mirror_user_id] = current_user.id if attrs[:import_url].present?
+
         project = ::Projects::CreateService.new(current_user, attrs).execute
 
         if project.saved?
@@ -172,6 +174,8 @@ module API
 
         attrs = declared_params(include_missing: false)
         attrs = translate_params_for_compatibility(attrs)
+        attrs[:mirror_user_id] = user.id if attrs[:import_url].present?
+
         project = ::Projects::CreateService.new(user, attrs).execute
 
         if project.saved?
@@ -284,13 +288,17 @@ module API
         optional :name, type: String, desc: 'The name of the project'
         optional :default_branch, type: String, desc: 'The default branch of the project'
         optional :path, type: String, desc: 'The path of the repository'
+        optional :import_url, type: String, desc: 'URL from which the project is imported'
 
         # EE
         at_least_one_of_ee = [
           :approvals_before_merge,
           :repository_storage,
-          :external_authorization_classification_label
+          :external_authorization_classification_label,
+          :import_url
         ]
+        optional :only_mirror_protected_branches, type: Boolean, desc: 'Only mirror protected branches'
+        optional :mirror_overwrites_diverged_branches, type: Boolean, desc: 'Pull mirror overwrites diverged branches'
 
         use :optional_project_params
         at_least_one_of(*(at_least_one_of_ce + at_least_one_of_ee))
@@ -302,6 +310,7 @@ module API
         authorize! :change_visibility_level, user_project if attrs[:visibility].present?
 
         attrs = translate_params_for_compatibility(attrs)
+        attrs[:mirror_user_id] = current_user.id unless valid_mirror_user?(attrs)
 
         result = ::Projects::UpdateService.new(user_project, current_user, attrs).execute