Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8c92afc3
Commit
8c92afc3
authored
Jun 13, 2019
by
George Tsiolis
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove tooltip directive on project avatar image component
parent
18344feb
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
21 deletions
+5
-21
app/assets/javascripts/vue_shared/components/project_avatar/image.vue
...avascripts/vue_shared/components/project_avatar/image.vue
+0
-21
changelogs/unreleased/gt-remove-tooltip-directive-on-project-avatar-image-component.yml
...e-tooltip-directive-on-project-avatar-image-component.yml
+5
-0
No files found.
app/assets/javascripts/vue_shared/components/project_avatar/image.vue
View file @
8c92afc3
...
@@ -17,13 +17,9 @@
...
@@ -17,13 +17,9 @@
import
defaultAvatarUrl
from
'
images/no_avatar.png
'
;
import
defaultAvatarUrl
from
'
images/no_avatar.png
'
;
import
{
placeholderImage
}
from
'
../../../lazy_loader
'
;
import
{
placeholderImage
}
from
'
../../../lazy_loader
'
;
import
tooltip
from
'
../../directives/tooltip
'
;
export
default
{
export
default
{
name
:
'
ProjectAvatarImage
'
,
name
:
'
ProjectAvatarImage
'
,
directives
:
{
tooltip
,
},
props
:
{
props
:
{
lazy
:
{
lazy
:
{
type
:
Boolean
,
type
:
Boolean
,
...
@@ -50,16 +46,6 @@ export default {
...
@@ -50,16 +46,6 @@ export default {
required
:
false
,
required
:
false
,
default
:
20
,
default
:
20
,
},
},
tooltipText
:
{
type
:
String
,
required
:
false
,
default
:
''
,
},
tooltipPlacement
:
{
type
:
String
,
required
:
false
,
default
:
'
top
'
,
},
},
},
computed
:
{
computed
:
{
// API response sends null when gravatar is disabled and
// API response sends null when gravatar is disabled and
...
@@ -71,9 +57,6 @@ export default {
...
@@ -71,9 +57,6 @@ export default {
resultantSrcAttribute
()
{
resultantSrcAttribute
()
{
return
this
.
lazy
?
placeholderImage
:
this
.
sanitizedSource
;
return
this
.
lazy
?
placeholderImage
:
this
.
sanitizedSource
;
},
},
tooltipContainer
()
{
return
this
.
tooltipText
?
'
body
'
:
null
;
},
avatarSizeClass
()
{
avatarSizeClass
()
{
return
`s
${
this
.
size
}
`
;
return
`s
${
this
.
size
}
`
;
},
},
...
@@ -83,7 +66,6 @@ export default {
...
@@ -83,7 +66,6 @@ export default {
<
template
>
<
template
>
<img
<img
v-tooltip
:class=
"
{
:class=
"
{
lazy: lazy,
lazy: lazy,
[avatarSizeClass]: true,
[avatarSizeClass]: true,
...
@@ -94,9 +76,6 @@ export default {
...
@@ -94,9 +76,6 @@ export default {
:height="size"
:height="size"
:alt="imgAlt"
:alt="imgAlt"
:data-src="sanitizedSource"
:data-src="sanitizedSource"
:data-container="tooltipContainer"
:data-placement="tooltipPlacement"
:title="tooltipText"
class="avatar"
class="avatar"
/>
/>
</
template
>
</
template
>
changelogs/unreleased/gt-remove-tooltip-directive-on-project-avatar-image-component.yml
0 → 100644
View file @
8c92afc3
---
title
:
Remove tooltip directive on project avatar image component
merge_request
:
29631
author
:
George Tsiolis
type
:
performance
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment