Commit 8d9150b6 authored by Hordur Freyr Yngvason's avatar Hordur Freyr Yngvason

Merge error conditions into one

parent bb87444a
...@@ -13,14 +13,7 @@ module Clusters ...@@ -13,14 +13,7 @@ module Clusters
if management_project_id.present? if management_project_id.present?
management_project = management_project_scope(cluster).find_by_id(management_project_id) management_project = management_project_scope(cluster).find_by_id(management_project_id)
unless management_project unless management_project && can_admin_pipeline_for_project?(management_project)
cluster.errors.add(:management_project_id, _('Project does not exist or you don\'t have permission to perform this action'))
return false
end
unless can_admin_pipeline_for_project?(management_project)
# Use same message as not found to prevent enumeration
cluster.errors.add(:management_project_id, _('Project does not exist or you don\'t have permission to perform this action')) cluster.errors.add(:management_project_id, _('Project does not exist or you don\'t have permission to perform this action'))
return false return false
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment