Commit 90490597 authored by Dmytro Zaporozhets (DZ)'s avatar Dmytro Zaporozhets (DZ)

Merge branch '276948-clean-extra-ff-check-editor-unique-counter' into 'master'

Remove extra check from ff in editor_unique_counter [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!60360
parents 36c9bb54 39624094
...@@ -50,7 +50,6 @@ module Gitlab ...@@ -50,7 +50,6 @@ module Gitlab
private private
def track_unique_action(action, author, time) def track_unique_action(action, author, time)
return unless Feature.enabled?(:track_editor_edit_actions, default_enabled: true)
return unless author return unless author
Gitlab::UsageDataCounters::HLLRedisCounter.track_event(action, values: author.id, time: time) Gitlab::UsageDataCounters::HLLRedisCounter.track_event(action, values: author.id, time: time)
......
...@@ -28,14 +28,6 @@ RSpec.describe Gitlab::UsageDataCounters::EditorUniqueCounter, :clean_gitlab_red ...@@ -28,14 +28,6 @@ RSpec.describe Gitlab::UsageDataCounters::EditorUniqueCounter, :clean_gitlab_red
it 'does not track edit actions if author is not present' do it 'does not track edit actions if author is not present' do
expect(track_action(author: nil)).to be_nil expect(track_action(author: nil)).to be_nil
end end
context 'when feature flag track_editor_edit_actions is disabled' do
it 'does not track edit actions' do
stub_feature_flags(track_editor_edit_actions: false)
expect(track_action(author: user1)).to be_nil
end
end
end end
context 'for web IDE edit actions' do context 'for web IDE edit actions' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment