Commit 905ebd94 authored by Stan Hu's avatar Stan Hu

Set workhorse_extract_filename_base feature flag to default

Before this feature flag was enabled, Workhorse would reject any
multipart filename that contained a slash (e.g. `dist/release.tar.gz`),
even though GitLab never used the path in determining whether to store
the file. With this feature flag enabled, Workhorse extracts the base
from this filename so this path is effectively ignored. This allows
uploads via the API to work as before the endpoint was accelerated by
Workhorse.

Relates to:

1. https://gitlab.com/gitlab-org/gitlab/-/issues/326379
2. https://gitlab.com/gitlab-org/gitlab/-/issues/326350
parent e9f4ce15
...@@ -187,7 +187,7 @@ module ObjectStorage ...@@ -187,7 +187,7 @@ module ObjectStorage
hash[:TempPath] = workhorse_local_upload_path hash[:TempPath] = workhorse_local_upload_path
end end
hash[:FeatureFlagExtractBase] = Feature.enabled?(:workhorse_extract_filename_base) hash[:FeatureFlagExtractBase] = Feature.enabled?(:workhorse_extract_filename_base, default_enabled: :yaml)
hash[:MaximumSize] = maximum_size if maximum_size.present? hash[:MaximumSize] = maximum_size if maximum_size.present?
end end
end end
......
---
title: Set workhorse_extract_filename_base feature flag to default
merge_request: 58504
author:
type: changed
...@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/326379 ...@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/326379
milestone: '13.11' milestone: '13.11'
type: development type: development
group: group::source code group: group::source code
default_enabled: false default_enabled: true
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment