Merge branch 'jivanvl-remove-runner-instructions-ff' into 'master'

Remove runner_instructions ff

See merge request gitlab-org/gitlab!53087

app/assets/javascripts/pages/admin/runners/index.js

@@ -10,7 +10,5 @@ document.addEventListener('DOMContentLoaded', () => {
     useDefaultState: true,
   });
 
-  if (gon?.features?.runnerInstructions) {
   initInstallRunner();
-  }
 });

app/assets/javascripts/pages/groups/settings/ci_cd/show/index.js

@@ -20,7 +20,5 @@ document.addEventListener('DOMContentLoaded', () => {
   initSharedRunnersForm();
   initVariableList();
 
-  if (gon?.features?.runnerInstructions) {
   initInstallRunner();
-  }
 });

app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js

@@ -41,7 +41,5 @@ document.addEventListener('DOMContentLoaded', () => {
     initSharedRunnersToggle();
   }
 
-  if (gon?.features?.runnerInstructions) {
   initInstallRunner();
-  }
 });

app/controllers/admin/runners_controller.rb

@@ -4,9 +4,6 @@ class Admin::RunnersController < Admin::ApplicationController
   include RunnerSetupScripts
 
   before_action :runner, except: [:index, :tag_list, :runner_setup_scripts]
-  before_action do
-    push_frontend_feature_flag(:runner_instructions, default_enabled: :yaml)
-  end
 
   feature_category :continuous_integration
 

app/controllers/groups/settings/ci_cd_controller.rb

@@ -9,9 +9,6 @@ module Groups
       before_action :authorize_admin_group!
       before_action :authorize_update_max_artifacts_size!, only: [:update]
       before_action :define_variables, only: [:show]
-      before_action do
-        push_frontend_feature_flag(:runner_instructions, @group, default_enabled: :yaml)
-      end
 
       feature_category :continuous_integration
 

app/controllers/projects/settings/ci_cd_controller.rb

@@ -12,7 +12,6 @@ module Projects
       before_action do
         push_frontend_feature_flag(:ajax_new_deploy_token, @project)
         push_frontend_feature_flag(:vueify_shared_runners_toggle, @project)
-        push_frontend_feature_flag(:runner_instructions, @project, default_enabled: :yaml)
       end
 
       helper_method :highlight_badge

changelogs/unreleased/jivanvl-remove-runner-instructions-ff.yml

+---
+title: Add runner instructions modal in the CI/CD settings section
+merge_request: 53087
+author:
+type: changed

config/feature_flags/development/runner_instructions.yml

----
-name: runner_instructions
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/51014
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/296818
-milestone: '13.9'
-type: development
-group: group::"continuous integration"
-default_enabled: false