Commit 95fa62fe authored by Marcia Ramos's avatar Marcia Ramos

Merge branch 'ajk-update-db-review-required' into 'master'

Update the migration MR requirements

See merge request gitlab-org/gitlab!69768
parents df19afb1 7dfc8154
...@@ -38,13 +38,24 @@ migration only. ...@@ -38,13 +38,24 @@ migration only.
### Required ### Required
The following artifacts are required prior to submitting for a ~database review. You must provide the following artifacts when you request a ~database review.
If your merge request description does not include these items, the review will be reassigned back to the author. If your merge request description does not include these items, the review will be reassigned back to the author.
#### Migrations
If new migrations are introduced, in the MR **you are required to provide**: If new migrations are introduced, in the MR **you are required to provide**:
- The output of both migrating (`db:migrate`) and rolling back (`db:rollback`) for all migrations. - The output of both migrating (`db:migrate`) and rolling back (`db:rollback`) for all migrations.
Note that we have automated tooling for
[GitLab](https://gitlab.com/gitlab-org/gitlab) (provided by the
`db:check-migrations` pipeline job) that provides this output for migrations on
~database merge requests. You do not need to provide this information manually
if the bot can do it for you. The bot also checks that migrations are correctly
reversible.
#### Queries
If new queries have been introduced or existing queries have been updated, **you are required to provide**: If new queries have been introduced or existing queries have been updated, **you are required to provide**:
- [Query plans](#query-plans) for each raw SQL query included in the merge request along with the link to the query plan following each raw SQL snippet. - [Query plans](#query-plans) for each raw SQL query included in the merge request along with the link to the query plan following each raw SQL snippet.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment