Merge branch '350603-cablett-project-owner-specs-10' into 'master'

Replace owner with first_owner in request specs

See merge request gitlab-org/gitlab!79003

spec/presenters/blob_presenter_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 
 RSpec.describe BlobPresenter do
   let_it_be(:project) { create(:project, :repository) }
-  let_it_be(:user) { project.owner }
+  let_it_be(:user) { project.first_owner }
 
   let(:repository) { project.repository }
   let(:blob) { repository.blob_at('HEAD', 'files/ruby/regex.rb') }

spec/requests/api/api_spec.rb

@@ -102,7 +102,7 @@ RSpec.describe API::API do
 
   describe 'logging', :aggregate_failures do
     let_it_be(:project) { create(:project, :public) }
-    let_it_be(:user) { project.owner }
+    let_it_be(:user) { project.first_owner }
 
     context 'when the endpoint is handled by the application' do
       context 'when the endpoint supports all possible fields' do

spec/requests/api/ci/pipelines_spec.rb

@@ -988,7 +988,7 @@ RSpec.describe API::Ci::Pipelines do
 
   describe 'DELETE /projects/:id/pipelines/:pipeline_id' do
     context 'authorized user' do
-      let(:owner) { project.owner }
+      let(:owner) { project.first_owner }
 
       it 'destroys the pipeline' do
         delete api("/projects/#{project.id}/pipelines/#{pipeline.id}", owner)

spec/requests/api/ci/runners_reset_registration_token_spec.rb

@@ -138,7 +138,7 @@ RSpec.describe API::Ci::Runners do
       end
 
       include_context 'when authorized', 'project' do
-        let_it_be(:user) { project.owner }
+        let_it_be(:user) { project.first_owner }
 
         def get_token
           project.reload.runners_token

spec/requests/api/graphql/ci/ci_cd_setting_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe 'Getting Ci Cd Setting' do
   include GraphqlHelpers
 
   let_it_be_with_reload(:project) { create(:project, :repository) }
-  let_it_be(:current_user) { project.owner }
+  let_it_be(:current_user) { project.first_owner }
 
   let(:fields) do
     <<~QUERY

spec/requests/api/graphql/container_repository/container_repository_details_spec.rb

@@ -17,7 +17,7 @@ RSpec.describe 'container repository details' do
     )
   end
 
-  let(:user) { project.owner }
+  let(:user) { project.first_owner }
   let(:variables) { {} }
   let(:tags) { %w[latest tag1 tag2 tag3 tag4 tag5] }
   let(:container_repository_global_id) { container_repository.to_global_id.to_s }

spec/requests/api/graphql/gitlab_schema_spec.rb

@@ -166,7 +166,7 @@ RSpec.describe 'GitlabSchema configurations' do
     end
 
     context 'authentication' do
-      let(:current_user) { project.owner }
+      let(:current_user) { project.first_owner }
 
       it 'authenticates all queries' do
         subject
@@ -216,7 +216,7 @@ RSpec.describe 'GitlabSchema configurations' do
   context "global id's" do
     it 'uses GlobalID to expose ids' do
       post_graphql(graphql_query_for('project', { 'fullPath' => project.full_path }, %w(id)),
-                   current_user: project.owner)
+                   current_user: project.first_owner)
 
       parsed_id = GlobalID.parse(graphql_data['project']['id'])
 

spec/requests/api/graphql/mutations/ci/ci_cd_settings_update_spec.rb

@@ -45,7 +45,7 @@ RSpec.describe 'CiCdSettingsUpdate' do
   end
 
   context 'when authorized' do
-    let_it_be(:user) { project.owner }
+    let_it_be(:user) { project.first_owner }
 
     it 'updates ci cd settings' do
       post_graphql_mutation(mutation, current_user: user)

spec/requests/api/graphql/mutations/ci/job_token_scope/add_project_spec.rb

@@ -49,7 +49,7 @@ RSpec.describe 'CiJobTokenScopeAddProject' do
   end
 
   context 'when authorized' do
-    let_it_be(:current_user) { project.owner }
+    let_it_be(:current_user) { project.first_owner }
 
     before do
       target_project.add_developer(current_user)

spec/requests/api/graphql/mutations/ci/job_token_scope/remove_project_spec.rb

@@ -55,7 +55,7 @@ RSpec.describe 'CiJobTokenScopeRemoveProject' do
   end
 
   context 'when authorized' do
-    let_it_be(:current_user) { project.owner }
+    let_it_be(:current_user) { project.first_owner }
 
     before do
       target_project.add_guest(current_user)

spec/requests/api/graphql/mutations/ci/pipeline_destroy_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe 'PipelineDestroy' do
   include GraphqlHelpers
 
   let_it_be(:project) { create(:project) }
-  let_it_be(:user) { project.owner }
+  let_it_be(:user) { project.first_owner }
   let_it_be(:pipeline) { create(:ci_pipeline, :success, project: project, user: user) }
 
   let(:mutation) do

spec/requests/api/graphql/mutations/ci/runners_registration_token/reset_spec.rb

@@ -71,7 +71,7 @@ RSpec.describe 'RunnersRegistrationTokenReset' do
     end
 
     include_context 'when authorized', 'project' do
-      let_it_be(:user) { project.owner }
+      let_it_be(:user) { project.first_owner }
 
       def get_token
         project.reload.runners_token

spec/requests/api/graphql/mutations/security/ci_configuration/configure_sast_iac_spec.rb

@@ -12,7 +12,7 @@ RSpec.describe 'ConfigureSastIac' do
   let(:mutation_response) { graphql_mutation_response(:configureSastIac) }
 
   context 'when authorized' do
-    let_it_be(:user) { project.owner }
+    let_it_be(:user) { project.first_owner }
 
     it 'creates a branch with sast iac configured' do
       post_graphql_mutation(mutation, current_user: user)

spec/requests/api/graphql/mutations/security/ci_configuration/configure_secret_detection_spec.rb

@@ -12,7 +12,7 @@ RSpec.describe 'ConfigureSecretDetection' do
   let(:mutation_response) { graphql_mutation_response(:configureSecretDetection) }
 
   context 'when authorized' do
-    let_it_be(:user) { project.owner }
+    let_it_be(:user) { project.first_owner }
 
     it 'creates a branch with secret detection configured' do
       post_graphql_mutation(mutation, current_user: user)

spec/requests/api/graphql/project/container_expiration_policy_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe 'getting a repository in a project' do
   include GraphqlHelpers
 
   let_it_be(:project) { create(:project) }
-  let_it_be(:current_user) { project.owner }
+  let_it_be(:current_user) { project.first_owner }
   let_it_be(:container_expiration_policy) { project.container_expiration_policy }
 
   let(:fields) do

spec/requests/api/graphql/project/container_repositories_spec.rb

@@ -38,7 +38,7 @@ RSpec.describe 'getting container repositories in a project' do
     )
   end
 
-  let(:user) { project.owner }
+  let(:user) { project.first_owner }
   let(:variables) { {} }
   let(:container_repositories_response) { graphql_data.dig('project', 'containerRepositories', 'edges') }
   let(:container_repositories_count_response) { graphql_data.dig('project', 'containerRepositoriesCount') }

spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe 'getting a detailed sentry error' do
 
   let_it_be(:project) { create(:project, :repository) }
   let_it_be(:project_setting) { create(:project_error_tracking_setting, project: project) }
-  let_it_be(:current_user) { project.owner }
+  let_it_be(:current_user) { project.first_owner }
   let_it_be(:sentry_detailed_error) { build(:error_tracking_sentry_detailed_error) }
 
   let(:sentry_gid) { sentry_detailed_error.to_global_id.to_s }

spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe 'sentry errors requests' do
 
   let_it_be(:project) { create(:project, :repository) }
   let_it_be(:project_setting) { create(:project_error_tracking_setting, project: project) }
-  let_it_be(:current_user) { project.owner }
+  let_it_be(:current_user) { project.first_owner }
 
   let(:query) do
     graphql_query_for(

spec/requests/api/graphql/project/grafana_integration_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe 'Getting Grafana Integration' do
   include GraphqlHelpers
 
   let_it_be(:project) { create(:project, :repository) }
-  let_it_be(:current_user) { project.owner }
+  let_it_be(:current_user) { project.first_owner }
   let_it_be(:grafana_integration) { create(:grafana_integration, project: project) }
 
   let(:fields) do

spec/requests/api/graphql/project/issue/design_collection/versions_spec.rb

@@ -24,7 +24,7 @@ RSpec.describe 'Getting versions related to an issue' do
     create(:design_version, issue: issue)
   end
 
-  let_it_be(:owner) { issue.project.owner }
+  let_it_be(:owner) { issue.project.first_owner }
 
   def version_query(params = version_params)
     query_graphql_field(:versions, params, version_query_fields)

spec/requests/api/graphql/project/issue/designs/designs_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe 'Getting designs related to an issue' do
   include DesignManagementTestHelpers
 
   let_it_be(:design) { create(:design, :with_smaller_image_versions, versions_count: 1) }
-  let_it_be(:current_user) { design.project.owner }
+  let_it_be(:current_user) { design.project.first_owner }
 
   let(:design_query) do
     <<~NODE

spec/requests/api/graphql/project/issue/designs/notes_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe 'Getting designs related to an issue' do
   let_it_be(:project) { create(:project, :public) }
   let_it_be(:issue) { create(:issue, project: project) }
   let_it_be(:design) { create(:design, :with_file, versions_count: 1, issue: issue) }
-  let_it_be(:current_user) { project.owner }
+  let_it_be(:current_user) { project.first_owner }
   let_it_be(:note) { create(:diff_note_on_design, noteable: design, project: project) }
 
   before do

spec/requests/api/graphql/project/repository/blobs_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe 'getting blobs in a project repository' do
   include GraphqlHelpers
 
   let(:project) { create(:project, :repository) }
-  let(:current_user) { project.owner }
+  let(:current_user) { project.first_owner }
   let(:paths) { ["CONTRIBUTING.md", "README.md"] }
   let(:ref) { project.default_branch }
   let(:fields) do

spec/requests/api/graphql/project/repository_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe 'getting a repository in a project' do
   include GraphqlHelpers
 
   let(:project) { create(:project, :repository) }
-  let(:current_user) { project.owner }
+  let(:current_user) { project.first_owner }
   let(:fields) do
     <<~QUERY
       #{all_graphql_fields_for('repository'.classify)}

spec/requests/api/graphql/project/tree/tree_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe 'getting a tree in a project' do
   include GraphqlHelpers
 
   let(:project) { create(:project, :repository) }
-  let(:current_user) { project.owner }
+  let(:current_user) { project.first_owner }
   let(:path) { "" }
   let(:ref) { "master" }
   let(:fields) do

spec/requests/api/markdown_spec.rb

@@ -71,7 +71,7 @@ RSpec.describe API::Markdown do
           end
 
           context "when authorized" do
-            let(:user) { project.owner }
+            let(:user) { project.first_owner }
 
             it_behaves_like "rendered markdown text without GFM"
           end
@@ -97,7 +97,7 @@ RSpec.describe API::Markdown do
 
         context "with project" do
           let(:params) { { text: text, gfm: true, project: project.full_path } }
-          let(:user) { project.owner }
+          let(:user) { project.first_owner }
 
           it "renders markdown text" do
             expect(response).to have_gitlab_http_status(:created)

spec/requests/api/merge_requests_spec.rb

@@ -2896,7 +2896,7 @@ RSpec.describe API::MergeRequests do
 
         it 'is false for an unauthorized user' do
           expect do
-            put api("/projects/#{target_project.id}/merge_requests/#{merge_request.iid}", target_project.owner), params: { state_event: 'close', remove_source_branch: true }
+            put api("/projects/#{target_project.id}/merge_requests/#{merge_request.iid}", target_project.first_owner), params: { state_event: 'close', remove_source_branch: true }
           end.not_to change { merge_request.reload.merge_params }
 
           expect(response).to have_gitlab_http_status(:ok)

spec/requests/api/project_export_spec.rb

@@ -450,7 +450,7 @@ RSpec.describe API::ProjectExport, :clean_gitlab_redis_cache do
           expect_next_instance_of(Projects::ImportExport::ExportService) do |service|
             expect(service).to receive(:execute)
           end
-          post api(path, project.owner), params: params
+          post api(path, project.first_owner), params: params
 
           expect(response).to have_gitlab_http_status(:accepted)
         end

spec/requests/api/project_snapshots_spec.rb

@@ -33,7 +33,7 @@ RSpec.describe API::ProjectSnapshots do
     end
 
     it 'returns authentication error as project owner' do
-      get api("/projects/#{project.id}/snapshot", project.owner)
+      get api("/projects/#{project.id}/snapshot", project.first_owner)
 
       expect(response).to have_gitlab_http_status(:forbidden)
     end

spec/requests/api/projects_spec.rb

@@ -30,7 +30,7 @@ RSpec.shared_examples 'languages and percentages JSON response' do
 
   context 'when the languages were detected before' do
     before do
-      Projects::DetectRepositoryLanguagesService.new(project, project.owner).execute
+      Projects::DetectRepositoryLanguagesService.new(project, project.first_owner).execute
     end
 
     it 'returns the detection from the database' do
@@ -2710,7 +2710,7 @@ RSpec.describe API::Projects do
       it 'returns the project users' do
         get api("/projects/#{project.id}/users", current_user)
 
-        user = project.namespace.owner
+        user = project.namespace.first_owner
 
         expect(response).to have_gitlab_http_status(:ok)
         expect(response).to include_pagination_headers

spec/requests/boards/lists_controller_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 RSpec.describe Boards::ListsController do
   describe '#index' do
     let(:board) { create(:board) }
-    let(:user) { board.project.owner }
+    let(:user) { board.project.first_owner }
 
     it 'does not have N+1 queries' do
       login_as(user)

spec/requests/import/gitlab_projects_controller_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe Import::GitlabProjectsController do
   include_context 'workhorse headers'
 
   let_it_be(:namespace) { create(:namespace) }
-  let_it_be(:user) { namespace.owner }
+  let_it_be(:user) { namespace.first_owner }
 
   before do
     login_as(user)

spec/requests/projects/clusters/integrations_controller_spec.rb

@@ -28,7 +28,7 @@ RSpec.describe Projects::Clusters::IntegrationsController do
   describe 'POST create_or_update' do
     let(:cluster) { create(:cluster, :project, :provided_by_gcp) }
     let(:project) { cluster.project }
-    let(:user) { project.owner }
+    let(:user) { project.first_owner }
 
     it_behaves_like '#create_or_update action' do
       let(:path) { create_or_update_project_cluster_integration_path(project, cluster) }

spec/requests/projects/merge_requests/creations_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe 'merge requests creations' do
     include ProjectForksHelper
 
     let(:project) { create(:project, :repository) }
-    let(:user) { project.owner }
+    let(:user) { project.first_owner }
 
     before do
       login_as(user)

spec/requests/projects/merge_requests_discussions_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe 'merge requests discussions' do
   # Further tests can be found at merge_requests_controller_spec.rb
   describe 'GET /:namespace/:project/-/merge_requests/:iid/discussions' do
     let(:project) { create(:project, :repository, :public) }
-    let(:owner) { project.owner }
+    let(:owner) { project.first_owner }
     let(:user) { create(:user) }
     let(:merge_request) { create(:merge_request_with_diffs, target_project: project, source_project: project) }
 

spec/requests/projects/merge_requests_spec.rb

@@ -12,7 +12,7 @@ RSpec.describe 'merge requests actions' do
                                       reviewers: [user2])
   end
 
-  let(:user) { project.owner }
+  let(:user) { project.first_owner }
   let(:user2) { create(:user) }
 
   before do

spec/requests/projects/metrics_dashboard_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe 'Projects::MetricsDashboardController' do
   let_it_be(:project) { create(:project) }
   let_it_be(:environment) { create(:environment, project: project) }
   let_it_be(:environment2) { create(:environment, project: project) }
-  let_it_be(:user) { project.owner }
+  let_it_be(:user) { project.first_owner }
 
   before do
     project.add_developer(user)

spec/requests/projects/noteable_notes_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe 'Project noteable notes' do
     let(:etag_store) { Gitlab::EtagCaching::Store.new }
     let(:notes_path) { project_noteable_notes_path(project, target_type: merge_request.class.name.underscore, target_id: merge_request.id) }
     let(:project) { merge_request.project }
-    let(:user) { project.owner }
+    let(:user) { project.first_owner }
 
     let(:response_etag) { response.headers['ETag'] }
     let(:stored_etag) { "W/\"#{etag_store.get(notes_path)}\"" }