Commit 972562b4 authored by Justin Ho's avatar Justin Ho

Update helper spec

parent a1b819eb
...@@ -133,16 +133,16 @@ RSpec.describe EE::IntegrationsHelper do ...@@ -133,16 +133,16 @@ RSpec.describe EE::IntegrationsHelper do
it 'includes the required keys' do it 'includes the required keys' do
additions = subject.gitlab_slack_application_data(relation) additions = subject.gitlab_slack_application_data(relation)
expect(additions.keys).to match_array %w[ expect(additions.keys).to include(
projects :projects,
sign_in_path :sign_in_path,
is_signed_in :is_signed_in,
slack_link_profile_slack_path :slack_link_path,
gitlab_for_slack_gif_path :gitlab_for_slack_gif_path,
gitlab_logo_path :gitlab_logo_path,
slack_logo_path :slack_logo_path,
docs_path :docs_path
] )
end end
it 'does not suffer from N+1 performance issues' do it 'does not suffer from N+1 performance issues' do
...@@ -154,7 +154,7 @@ RSpec.describe EE::IntegrationsHelper do ...@@ -154,7 +154,7 @@ RSpec.describe EE::IntegrationsHelper do
end end
it 'serializes nil projects without error' do it 'serializes nil projects without error' do
expect(subject.gitlab_slack_application_data(nil)).to include('"projects":null') expect(subject.gitlab_slack_application_data(nil)).to include(projects: '[]')
end end
end end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment