Commit 9aa21e8b authored by Clement Ho's avatar Clement Ho

[skip ci] Code review improvements

parent b15e84e7
...@@ -53,9 +53,9 @@ import eventHub from './sidebar/event_hub'; ...@@ -53,9 +53,9 @@ import eventHub from './sidebar/event_hub';
$loading = $block.find('.block-loading').fadeOut(); $loading = $block.find('.block-loading').fadeOut();
var assignYourself = function () { const assignYourself = function () {
const unassignedSelected = $dropdown.closest('.selectbox') const unassignedSelected = $dropdown.closest('.selectbox')
.find("input[name='" + ($dropdown.data('field-name')) + "'][value=0]"); .find(`input[name='${$dropdown.data('field-name')}'][value=0]`);
if (unassignedSelected) { if (unassignedSelected) {
unassignedSelected.remove(); unassignedSelected.remove();
...@@ -82,18 +82,18 @@ import eventHub from './sidebar/event_hub'; ...@@ -82,18 +82,18 @@ import eventHub from './sidebar/event_hub';
$block[0].addEventListener('assignYourself', assignYourself); $block[0].addEventListener('assignYourself', assignYourself);
} }
var getSelectedUserInputs = function() { const getSelectedUserInputs = function() {
return $selectbox return $selectbox
.find(`input[name="${$dropdown.data('field-name')}"]`); .find(`input[name="${$dropdown.data('field-name')}"]`);
} }
var getSelected = function() { const getSelected = function() {
return getSelectedUserInputs() return getSelectedUserInputs()
.map((index, input) => parseInt(input.value, 10)) .map((index, input) => parseInt(input.value, 10))
.get(); .get();
}; };
var getMultiSelectDropdownTitle = function(selectedUser, isSelected) { const getMultiSelectDropdownTitle = function(selectedUser, isSelected) {
const selectedUsers = getSelected() const selectedUsers = getSelected()
.filter(u => u !== 0); .filter(u => u !== 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment