Use reload on let_it_be and remove unused after callbacks

ee/spec/requests/api/nuget_packages_spec.rb

@@ -6,7 +6,7 @@ describe API::NugetPackages do
   include EE::PackagesManagerApiSpecHelpers
 
   let_it_be(:user) { create(:user) }
-  let_it_be(:project) { create(:project, :public) }
+  let_it_be(:project, reload: true) { create(:project, :public) }
   let_it_be(:personal_access_token) { create(:personal_access_token, user: user) }
 
   describe 'GET /api/v4/projects/:id/packages/nuget' do
@@ -58,10 +58,6 @@ describe API::NugetPackages do
               project.update!(visibility_level: Gitlab::VisibilityLevel.const_get(project_visibility_level, false))
             end
 
-            after do
-              project.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
-            end
-
             it_behaves_like params[:shared_examples_name], params[:user_role], params[:expected_status], params[:member]
           end
         end
@@ -128,10 +124,6 @@ describe API::NugetPackages do
               project.update!(visibility_level: Gitlab::VisibilityLevel.const_get(project_visibility_level, false))
             end
 
-            after do
-              project.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
-            end
-
             it_behaves_like params[:shared_examples_name], params[:user_role], params[:expected_status], params[:member]
           end
         end
@@ -208,10 +200,6 @@ describe API::NugetPackages do
               project.update!(visibility_level: Gitlab::VisibilityLevel.const_get(project_visibility_level, false))
             end
 
-            after do
-              project.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
-            end
-
             it_behaves_like params[:shared_examples_name], params[:user_role], params[:expected_status], params[:member]
           end
         end
@@ -278,10 +266,6 @@ describe API::NugetPackages do
               project.update!(visibility_level: Gitlab::VisibilityLevel.const_get(project_visibility_level, false))
             end
 
-            after do
-              project.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
-            end
-
             it_behaves_like params[:shared_examples_name], params[:user_role], params[:expected_status], params[:member]
           end
 
@@ -348,10 +332,6 @@ describe API::NugetPackages do
               project.update!(visibility_level: Gitlab::VisibilityLevel.const_get(project_visibility_level, false))
             end
 
-            after do
-              project.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
-            end
-
             it_behaves_like params[:shared_examples_name], params[:user_role], params[:expected_status], params[:member]
           end
         end
@@ -420,10 +400,6 @@ describe API::NugetPackages do
               project.update!(visibility_level: Gitlab::VisibilityLevel.const_get(project_visibility_level, false))
             end
 
-            after do
-              project.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
-            end
-
             it_behaves_like params[:shared_examples_name], params[:user_role], params[:expected_status], params[:member]
           end
         end
@@ -491,10 +467,6 @@ describe API::NugetPackages do
               project.update!(visibility_level: Gitlab::VisibilityLevel.const_get(project_visibility_level, false))
             end
 
-            after do
-              project.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
-            end
-
             it_behaves_like params[:shared_examples_name], params[:user_role], params[:expected_status], params[:member]
           end
         end
@@ -569,10 +541,6 @@ describe API::NugetPackages do
               project.update!(visibility_level: Gitlab::VisibilityLevel.const_get(project_visibility_level, false))
             end
 
-            after do
-              project.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
-            end
-
             it_behaves_like params[:shared_examples_name], params[:user_role], params[:expected_status], params[:member]
           end
         end