Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9b0eecd8
Commit
9b0eecd8
authored
Sep 29, 2020
by
Sean McGivern
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add feature categories to controllers beginning with B
parent
1f5b0c38
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
11 additions
and
5 deletions
+11
-5
app/controllers/boards/issues_controller.rb
app/controllers/boards/issues_controller.rb
+2
-0
app/controllers/boards/lists_controller.rb
app/controllers/boards/lists_controller.rb
+2
-0
ee/app/controllers/boards/milestones_controller.rb
ee/app/controllers/boards/milestones_controller.rb
+1
-0
ee/app/controllers/boards/users_controller.rb
ee/app/controllers/boards/users_controller.rb
+1
-0
spec/controllers/every_controller_spec.rb
spec/controllers/every_controller_spec.rb
+5
-5
No files found.
app/controllers/boards/issues_controller.rb
View file @
9b0eecd8
...
...
@@ -21,6 +21,8 @@ module Boards
before_action
:validate_id_list
,
only:
[
:bulk_move
]
before_action
:can_move_issues?
,
only:
[
:bulk_move
]
feature_category
:boards
,
only:
[
:index
,
:create
,
:bulk_move
,
:update
]
def
index
list_service
=
Boards
::
Issues
::
ListService
.
new
(
board_parent
,
current_user
,
filter_params
)
issues
=
issues_from
(
list_service
)
...
...
app/controllers/boards/lists_controller.rb
View file @
9b0eecd8
...
...
@@ -8,6 +8,8 @@ module Boards
before_action
:authorize_read_list
,
only:
[
:index
]
skip_before_action
:authenticate_user!
,
only:
[
:index
]
feature_category
:boards
,
only:
[
:index
,
:create
,
:update
,
:destroy
,
:generate
]
def
index
lists
=
Boards
::
Lists
::
ListService
.
new
(
board
.
resource_parent
,
current_user
).
execute
(
board
)
...
...
ee/app/controllers/boards/milestones_controller.rb
View file @
9b0eecd8
...
...
@@ -5,6 +5,7 @@ module Boards
include
BoardsResponses
before_action
:authorize_read_milestone
,
only:
[
:index
]
feature_category
:boards
,
only:
[
:index
]
def
index
milestones_finder
=
Boards
::
MilestonesFinder
.
new
(
board
,
current_user
)
...
...
ee/app/controllers/boards/users_controller.rb
View file @
9b0eecd8
...
...
@@ -11,6 +11,7 @@ module Boards
include
BoardsResponses
before_action
:authorize_read_parent
,
only:
[
:index
]
feature_category
:boards
,
only:
[
:index
]
def
index
user_ids
=
user_finder
.
execute
.
select
(
:user_id
)
...
...
spec/controllers/every_controller_spec.rb
View file @
9b0eecd8
...
...
@@ -22,15 +22,15 @@ RSpec.describe "Every controller" do
let_it_be
(
:routes_without_category
)
do
controller_actions
.
map
do
|
controller
,
action
|
"
#{
controller
}
#
#{
action
}
"
unless
controller
.
feature_category_for_action
(
action
)
next
if
controller
.
feature_category_for_action
(
action
)
next
unless
controller
.
to_s
.
start_with?
(
'B'
)
"
#{
controller
}
#
#{
action
}
"
end
.
compact
end
it
"has feature categories"
do
pending
(
"We'll work on defining categories for all controllers: "
\
"https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/463"
)
expect
(
routes_without_category
).
to
be_empty
,
"
#{
routes_without_category
.
first
(
10
)
}
did not have a category"
expect
(
routes_without_category
).
to
be_empty
,
"
#{
routes_without_category
}
did not have a category"
end
it
"completed controllers don't get new routes without categories"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment