Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9cc2123e
Commit
9cc2123e
authored
Apr 25, 2018
by
Lin Jen-Shin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Select everything so we could hit protect
Add missing QA selectors as well
parent
c5f6c811
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
41 additions
and
9 deletions
+41
-9
app/views/projects/protected_branches/_create_protected_branch.html.haml
...cts/protected_branches/_create_protected_branch.html.haml
+2
-2
app/views/projects/protected_branches/_update_protected_branch.html.haml
...cts/protected_branches/_update_protected_branch.html.haml
+1
-1
qa/qa/factory/resource/branch.rb
qa/qa/factory/resource/branch.rb
+13
-1
qa/qa/page/project/settings/protected_branches.rb
qa/qa/page/project/settings/protected_branches.rb
+25
-5
No files found.
app/views/projects/protected_branches/_create_protected_branch.html.haml
View file @
9cc2123e
-
content_for
:merge_access_levels
do
-
content_for
:merge_access_levels
do
.merge_access_levels-container
.merge_access_levels-container
=
dropdown_tag
(
'Select'
,
=
dropdown_tag
(
'Select'
,
options:
{
toggle_class:
'js-allowed-to-merge wide'
,
options:
{
toggle_class:
'js-allowed-to-merge
qa-allowed-to-merge-select
wide'
,
dropdown_class:
'dropdown-menu-selectable capitalize-header'
,
dropdown_class:
'dropdown-menu-selectable
qa-allowed-to-merge-dropdown
capitalize-header'
,
data:
{
field_name:
'protected_branch[merge_access_levels_attributes][0][access_level]'
,
input_id:
'merge_access_levels_attributes'
}})
data:
{
field_name:
'protected_branch[merge_access_levels_attributes][0][access_level]'
,
input_id:
'merge_access_levels_attributes'
}})
-
content_for
:push_access_levels
do
-
content_for
:push_access_levels
do
.push_access_levels-container
.push_access_levels-container
...
...
app/views/projects/protected_branches/_update_protected_branch.html.haml
View file @
9cc2123e
%td
%td
=
hidden_field_tag
"allowed_to_merge_
#{
protected_branch
.
id
}
"
,
protected_branch
.
merge_access_levels
.
first
.
access_level
=
hidden_field_tag
"allowed_to_merge_
#{
protected_branch
.
id
}
"
,
protected_branch
.
merge_access_levels
.
first
.
access_level
=
dropdown_tag
(
(
protected_branch
.
merge_access_levels
.
first
.
humanize
||
'Select'
)
,
=
dropdown_tag
(
(
protected_branch
.
merge_access_levels
.
first
.
humanize
||
'Select'
)
,
options:
{
toggle_class:
'js-allowed-to-merge'
,
dropdown_class:
'dropdown-menu-selectable js-allowed-to-merge-container capitalize-header'
,
options:
{
toggle_class:
'js-allowed-to-merge
qa-allowed-to-merge
'
,
dropdown_class:
'dropdown-menu-selectable js-allowed-to-merge-container capitalize-header'
,
data:
{
field_name:
"allowed_to_merge_
#{
protected_branch
.
id
}
"
,
access_level_id:
protected_branch
.
merge_access_levels
.
first
.
id
}})
data:
{
field_name:
"allowed_to_merge_
#{
protected_branch
.
id
}
"
,
access_level_id:
protected_branch
.
merge_access_levels
.
first
.
id
}})
%td
%td
=
hidden_field_tag
"allowed_to_push_
#{
protected_branch
.
id
}
"
,
protected_branch
.
push_access_levels
.
first
.
access_level
=
hidden_field_tag
"allowed_to_push_
#{
protected_branch
.
id
}
"
,
protected_branch
.
push_access_levels
.
first
.
access_level
...
...
qa/qa/factory/resource/branch.rb
View file @
9cc2123e
...
@@ -2,7 +2,8 @@ module QA
...
@@ -2,7 +2,8 @@ module QA
module
Factory
module
Factory
module
Resource
module
Resource
class
Branch
<
Factory
::
Base
class
Branch
<
Factory
::
Base
attr_accessor
:project
,
:branch_name
,
:allow_to_push
,
:protected
attr_accessor
:project
,
:branch_name
,
:allow_to_push
,
:allow_to_merge
,
:protected
dependency
Factory
::
Resource
::
Project
,
as: :project
do
|
project
|
dependency
Factory
::
Resource
::
Project
,
as: :project
do
|
project
|
project
.
name
=
'protected-branch-project'
project
.
name
=
'protected-branch-project'
...
@@ -23,6 +24,7 @@ module QA
...
@@ -23,6 +24,7 @@ module QA
def
initialize
def
initialize
@branch_name
=
'test/branch'
@branch_name
=
'test/branch'
@allow_to_push
=
true
@allow_to_push
=
true
@allow_to_merge
=
true
@protected
=
false
@protected
=
false
end
end
...
@@ -63,6 +65,16 @@ module QA
...
@@ -63,6 +65,16 @@ module QA
page
.
allow_no_one_to_push
page
.
allow_no_one_to_push
end
end
if
allow_to_merge
page
.
allow_devs_and_masters_to_merge
else
page
.
allow_no_one_to_merge
end
page
.
wait
(
reload:
false
)
do
!
page
.
first
(
'.btn-create'
).
disabled?
end
page
.
protect_branch
page
.
protect_branch
end
end
end
end
...
...
qa/qa/page/project/settings/protected_branches.rb
View file @
9cc2123e
...
@@ -11,6 +11,13 @@ module QA
...
@@ -11,6 +11,13 @@ module QA
view
'app/views/projects/protected_branches/_create_protected_branch.html.haml'
do
view
'app/views/projects/protected_branches/_create_protected_branch.html.haml'
do
element
:allowed_to_push_select
element
:allowed_to_push_select
element
:allowed_to_push_dropdown
element
:allowed_to_push_dropdown
element
:allowed_to_merge_select
element
:allowed_to_merge_dropdown
end
view
'app/views/projects/protected_branches/_update_protected_branch.html.haml'
do
element
:allowed_to_push
element
:allowed_to_merge
end
end
view
'app/views/projects/protected_branches/shared/_branches_list.html.haml'
do
view
'app/views/projects/protected_branches/shared/_branches_list.html.haml'
do
...
@@ -30,11 +37,19 @@ module QA
...
@@ -30,11 +37,19 @@ module QA
end
end
def
allow_no_one_to_push
def
allow_no_one_to_push
allow_to_push
(
'No one'
)
click_allow
(
:push
,
'No one'
)
end
end
def
allow_devs_and_masters_to_push
def
allow_devs_and_masters_to_push
allow_to_push
(
'Developers + Masters'
)
click_allow
(
:push
,
'Developers + Masters'
)
end
def
allow_no_one_to_merge
click_allow
(
:merge
,
'No one'
)
end
def
allow_devs_and_masters_to_merge
click_allow
(
:merge
,
'Developers + Masters'
)
end
end
def
protect_branch
def
protect_branch
...
@@ -55,11 +70,16 @@ module QA
...
@@ -55,11 +70,16 @@ module QA
private
private
def
allow_to_push
(
text
)
def
click_allow
(
action
,
text
)
click_element
:allowed_to_push_select
click_element
:"allowed_to_
#{
action
}
_select"
within_element
(
:
allowed_to_push_dropdown
)
do
within_element
(
:
"allowed_to_
#{
action
}
_dropdown"
)
do
click_on
text
click_on
text
wait
(
reload:
false
)
do
has_css?
(
'.is-active'
)
end
end
end
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment