Link external commit status badge to a target URL

Using new detailed statuses factory for external commit statuses.

app/models/generic_commit_status.rb

@@ -12,4 +12,10 @@ class GenericCommitStatus < CommitStatus
   def tags
     [:external]
   end
+
+  def detailed_status(current_user)
+    Gitlab::Ci::Status::External::Factory
+      .new(self, current_user)
+      .fabricate!
+  end
 end

lib/gitlab/ci/status/external/common.rb

@@ -4,8 +4,8 @@ module Gitlab
       module External
         module Common
           def has_details?
-            can?(user, :read_commit_status, subject) &&
-              subject.target_url.present?
+            subject.target_url.present? &&
+              can?(user, :read_commit_status, subject)
           end
 
           def details_path

spec/features/projects/pipelines/pipeline_spec.rb

@@ -36,7 +36,8 @@ describe 'Pipeline', :feature, :js do
       create(:generic_commit_status, status: 'success',
                                      pipeline: pipeline,
                                      name: 'jenkins',
-                                     stage: 'external')
+                                     stage: 'external',
+                                     target_url: 'http://gitlab.com/status')
     end
   end
 
@@ -139,6 +140,7 @@ describe 'Pipeline', :feature, :js do
         it 'shows the success icon and the generic comit status build' do
           expect(page).to have_selector('.ci-status-icon-success')
           expect(page).to have_content('jenkins')
+          expect(page).to have_link('jenkins', href: 'http://gitlab.com/status')
         end
       end
     end