Merge branch 'add-missing-application-helper-specs' into 'master'

Add missing ApplicationHelper specs for promo URLs

See merge request gitlab-org/gitlab!38869

spec/helpers/application_helper_spec.rb

@@ -168,15 +168,38 @@ RSpec.describe ApplicationHelper do
     it { expect(helper.active_when(false)).to eq(nil) }
   end
 
+  describe '#promo_host' do
+    subject { helper.promo_host }
+
+    it 'returns the url' do
+      is_expected.to eq('about.gitlab.com')
+    end
+  end
+
+  describe '#promo_url' do
+    subject { helper.promo_url }
+
+    it 'returns the url' do
+      is_expected.to eq('https://about.gitlab.com')
+    end
+
+    it 'changes if promo_host changes' do
+      allow(helper).to receive(:promo_host).and_return('foobar.baz')
+
+      is_expected.to eq('https://foobar.baz')
+    end
+  end
+
   describe '#contact_sales_url' do
     subject { helper.contact_sales_url }
 
-    it 'passes a smoke test' do
+    it 'returns the url' do
       is_expected.to eq('https://about.gitlab.com/sales')
     end
 
     it 'changes if promo_url changes' do
       allow(helper).to receive(:promo_url).and_return('https://somewhere.else')
+
       is_expected.to eq('https://somewhere.else/sales')
     end
   end