Merge branch '299366-feature-flag-rollout-of-board_new_list' into 'master'

Enable board_new_list and iteration_board_lists feature flags by default

See merge request gitlab-org/gitlab!57439

config/feature_flags/development/board_new_list.yml

@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/299366
 milestone: '13.8'
 type: development
 group: group::project management
-default_enabled: false
+default_enabled: true

doc/user/project/issue_board.md

@@ -342,14 +342,16 @@ As in other list types, click the trash icon to remove a list.
 
 ### Iteration lists **(PREMIUM)**
 
-> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/250479) in GitLab 13.10.
-> - It's [deployed behind the `board_new_lists` and `iteration_board_lists` feature flags](../feature_flags.md), disabled by default.
-> - It's disabled on GitLab.com.
-> - It's recommended for production use.
-> - To use it in GitLab self-managed instances, ask a GitLab administrator to enable the feature flags: [`board_new_lists`](#enable-or-disable-new-add-list-form) and [`iteration_board_lists`](#enable-or-disable-iteration-lists-in-boards).
+> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/250479) in GitLab 13.11.
+> - [Deployed behind the `board_new_lists` and `iteration_board_lists` feature flags](../feature_flags.md), disabled by default.
+> - [Enabled by default](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/57439) in GitLab 13.11.
+> - Enabled on GitLab.com.
+> - Recommended for production use.
+> - For GitLab self-managed instances, GitLab administrators can opt to disable the feature flags: [`board_new_lists`](#enable-or-disable-new-add-list-form) and [`iteration_board_lists`](#enable-or-disable-iteration-lists-in-boards). **(PREMIUM SELF)**
 
-WARNING:
-This feature might not be available to you. Check the **version history** note above for details.
+There can be
+[risks when disabling released features](../feature_flags.md#risks-when-disabling-released-features).
+Refer to this feature's version history for more details.
 
 You're also able to create lists of an iteration.
 These are lists that filter issues by the assigned
@@ -646,10 +648,10 @@ Feature.disable(:graphql_board_lists)
 
 ### Enable or disable new add list form **(FREE SELF)**
 
-The new form for adding lists is under development and not ready for production use. It is
-deployed behind a feature flag that is **disabled by default**.
+The new form for adding lists is under development but ready for production use. It is
+deployed behind a feature flag that is **enabled by default**.
 [GitLab administrators with access to the GitLab Rails console](../../administration/feature_flags.md)
-can enable it.
+can disable it.
 
 To enable it:
 
@@ -666,12 +668,12 @@ Feature.disable(:board_new_list)
 ### Enable or disable iteration lists in boards **(PREMIUM SELF)**
 
 NOTE:
-To enable iteration lists in boards, you also need to enable the [new add list form](#enable-or-disable-new-add-list-form).
+When disabling iteration lists in boards, you also need to disable the [new add list form](#enable-or-disable-new-add-list-form).
 
-The iteration list is under development and not ready for production use. It is
-deployed behind a feature flag that is **disabled by default**.
+The iteration list is under development but ready for production use. It is
+deployed behind a feature flag that is **enabled by default**.
 [GitLab administrators with access to the GitLab Rails console](../../administration/feature_flags.md)
-can enable it.
+can disable it.
 
 To enable it:
 

ee/app/services/ee/boards/issues/list_service.rb

@@ -65,7 +65,7 @@ module EE
         def all_iteration_lists
           # Note that the names are very similar but these are different.
           # One is a license name and the other is a feature flag
-          if parent.feature_available?(:board_iteration_lists) && ::Feature.enabled?(:iteration_board_lists, parent)
+          if parent.feature_available?(:board_iteration_lists) && ::Feature.enabled?(:iteration_board_lists, parent, default_enabled: :yaml)
             board.lists.iteration.where.not(iteration_id: nil)
           else
             ::List.none

ee/app/services/ee/boards/issues/move_service.rb

@@ -39,7 +39,7 @@ module EE
             milestone_id: milestone_id
           }
 
-          movement_args[:sprint_id] = iteration_id(issue) if ::Feature.enabled?(:iteration_board_lists, parent)
+          movement_args[:sprint_id] = iteration_id(issue) if ::Feature.enabled?(:iteration_board_lists, parent, default_enabled: :yaml)
 
           movement_args
         end

ee/app/services/ee/boards/lists/create_service.rb

@@ -10,7 +10,7 @@ module EE
 
         override :execute
         def execute(board)
-          return ServiceResponse.error(message: 'iteration_board_lists feature flag is disabled') if type == :iteration && ::Feature.disabled?(:iteration_board_lists, board.resource_parent)
+          return ServiceResponse.error(message: 'iteration_board_lists feature flag is disabled') if type == :iteration && ::Feature.disabled?(:iteration_board_lists, board.resource_parent, default_enabled: :yaml)
           return license_validation_error unless valid_license?(board.resource_parent)
 
           super

ee/app/services/ee/boards/lists/list_service.rb

@@ -18,7 +18,7 @@ module EE
         def unavailable_list_types_for(board)
           list_types = super
           list_types += unlicensed_lists_for(board)
-          list_types << ::List.list_types[:iteration] if ::Feature.disabled?(:iteration_board_lists, board.resource_parent)
+          list_types << ::List.list_types[:iteration] if ::Feature.disabled?(:iteration_board_lists, board.resource_parent, default_enabled: :yaml)
 
           list_types.uniq
         end

ee/changelogs/unreleased/299366-feature-flag-rollout-of-board_new_list.yml

+---
+title: Enable iteration lists and new create list form
+merge_request: 57439
+author:
+type: changed

ee/config/feature_flags/development/iteration_board_lists.yml

@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/250479
 milestone: '13.7'
 type: development
 group: group::project management
-default_enabled: false
+default_enabled: true