Merge branch '338782-make-repository-update-mirror-worker-idempotent' into 'master'

Make RepositoryUpdateMirrorWorker idempotent

See merge request gitlab-org/gitlab!69725

ee/app/workers/all_queues.yml

@@ -1127,7 +1127,7 @@
   :urgency: :low
   :resource_boundary: :unknown
   :weight: 1
-  :idempotent:
+  :idempotent: true
   :tags: []
 - :name: requirements_management_import_requirements_csv
   :worker_name: RequirementsManagement::ImportRequirementsCsvWorker

ee/app/workers/repository_update_mirror_worker.rb

 # frozen_string_literal: true
 
-class RepositoryUpdateMirrorWorker # rubocop:disable Scalability/IdempotentWorker
+class RepositoryUpdateMirrorWorker
   UpdateError = Class.new(StandardError)
 
   include ApplicationWorker
 
+  idempotent!
   data_consistency :always
-  include Gitlab::ShellAdapter
   include ProjectStartImport
 
   feature_category :source_code_management

ee/spec/workers/repository_update_mirror_worker_spec.rb

@@ -8,8 +8,10 @@ RSpec.describe RepositoryUpdateMirrorWorker do
     let!(:project) { create(:project) }
     let!(:import_state) { create(:import_state, :mirror, :scheduled, project: project) }
 
+    subject(:worker) { described_class.new }
+
     before do
-      allow(subject).to receive(:jid).and_return(jid)
+      allow(worker).to receive(:jid).and_return(jid)
     end
 
     it 'sets status as finished when update mirror service executes successfully' do
@@ -58,5 +60,15 @@ RSpec.describe RepositoryUpdateMirrorWorker do
         expect { subject.perform(started_project.id) }.to change { import_state.reload.status }.to('finished')
       end
     end
+
+    it_behaves_like 'an idempotent worker' do
+      let(:job_args) { [project.id] }
+
+      before do
+        allow_next_instance_of(Projects::UpdateMirrorService) do |instance|
+          allow(instance).to receive(:execute).and_return(status: :success)
+        end
+      end
+    end
   end
 end