Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a65f9ffb
Commit
a65f9ffb
authored
Feb 10, 2021
by
Tom Quirk
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use gitlabWebUrl for issuable item
parent
4a1898a6
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
4 deletions
+7
-4
app/assets/javascripts/issuable_list/components/issuable_item.vue
...ts/javascripts/issuable_list/components/issuable_item.vue
+7
-4
No files found.
app/assets/javascripts/issuable_list/components/issuable_item.vue
View file @
a65f9ffb
...
...
@@ -47,17 +47,20 @@ export default {
author
()
{
return
this
.
issuable
.
author
;
},
webUrl
()
{
return
this
.
issuable
.
gitlabWebUrl
||
this
.
issuable
.
webUrl
;
},
authorId
()
{
return
getIdFromGraphQLId
(
`
${
this
.
author
.
id
}
`
);
},
isIssuableUrlExternal
()
{
// Check if URL is relative, which means it is internal.
if
(
!
/^https
?
:
\/\/
/g
.
test
(
this
.
issuable
.
webUrl
))
{
if
(
!
/^https
?
:
\/\/
/g
.
test
(
this
.
webUrl
))
{
return
false
;
}
// In case URL is absolute, it may or may not be internal,
// hence use `gon.gitlab_url` which is current instance domain.
return
!
this
.
issuable
.
webUrl
.
includes
(
gon
.
gitlab_url
);
return
!
this
.
webUrl
.
includes
(
gon
.
gitlab_url
);
},
labels
()
{
return
this
.
issuable
.
labels
?.
nodes
||
this
.
issuable
.
labels
||
[];
...
...
@@ -144,7 +147,7 @@ export default {
name=
"eye-slash"
:title=
"__('Confidential')"
/>
<gl-link
:href=
"
issuable.
webUrl"
v-bind=
"issuableTitleProps"
<gl-link
:href=
"webUrl"
v-bind=
"issuableTitleProps"
>
{{
issuable
.
title
}}
<gl-icon
v-if=
"isIssuableUrlExternal"
name=
"external-link"
class=
"gl-ml-2"
/></gl-link>
...
...
@@ -206,7 +209,7 @@ export default {
<gl-link
v-gl-tooltip:tooltipcontainer
.
top
:title=
"__('Comments')"
:href=
"`$
{
issuable.
webUrl}#notes`"
:href=
"`$
{webUrl}#notes`"
:class="{ 'no-comments': !issuable.userDiscussionsCount }"
class="gl-reset-color!"
>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment