Commit a932042a authored by Rajat Jain's avatar Rajat Jain Committed by Eugenia Grieff

Async import epics_select_bundle

parent 1f775605
...@@ -8,7 +8,6 @@ import issueStatusSelect from './issue_status_select'; ...@@ -8,7 +8,6 @@ import issueStatusSelect from './issue_status_select';
import subscriptionSelect from './subscription_select'; import subscriptionSelect from './subscription_select';
import LabelsSelect from './labels_select'; import LabelsSelect from './labels_select';
import issueableEventHub from './issuables_list/eventhub'; import issueableEventHub from './issuables_list/eventhub';
import EpicSelect from 'ee_else_ce/vue_shared/components/sidebar/epics_select/epics_select_bundle';
const HIDDEN_CLASS = 'hidden'; const HIDDEN_CLASS = 'hidden';
const DISABLED_CONTENT_CLASS = 'disabled-content'; const DISABLED_CONTENT_CLASS = 'disabled-content';
...@@ -72,8 +71,13 @@ export default class IssuableBulkUpdateSidebar { ...@@ -72,8 +71,13 @@ export default class IssuableBulkUpdateSidebar {
}) })
.catch(() => {}); .catch(() => {});
} }
if (EpicSelect) {
if (IS_EE) {
import('ee/vue_shared/components/sidebar/epics_select/epics_select_bundle')
.then(({ default: EpicSelect }) => {
EpicSelect(); EpicSelect();
})
.catch(() => {});
} }
} }
......
...@@ -52,13 +52,6 @@ ...@@ -52,13 +52,6 @@
.filter-item.health-status.health-status-filter .filter-item.health-status.health-status-filter
#js-bulk-update-health-status-root #js-bulk-update-health-status-root
%input{ id: 'issue_health_status_value', type: 'hidden', name: 'update[health_status]' } %input{ id: 'issue_health_status_value', type: 'hidden', name: 'update[health_status]' }
- if epic_bulk_edit_flag
.block
.title
= _('Epic')
.filter-item.epic-bulk-edit
#js-epic-select-root{ data: { group_id: @project&.group&.id, show_header: "true" } }
%input{ id: 'issue_epic_id', type: 'hidden', name: 'update[epic_id]' }
.block .block
.title .title
= _('Subscriptions') = _('Subscriptions')
...@@ -72,6 +65,5 @@ ...@@ -72,6 +65,5 @@
%a{ href: "#", data: { id: "unsubscribe" } } %a{ href: "#", data: { id: "unsubscribe" } }
= _('Unsubscribe') = _('Unsubscribe')
= hidden_field_tag "update[issuable_ids]", [] = hidden_field_tag "update[issuable_ids]", []
= hidden_field_tag :state_event, params[:state_event] = hidden_field_tag :state_event, params[:state_event]
...@@ -27,8 +27,6 @@ module EE ...@@ -27,8 +27,6 @@ module EE
set_health_status set_health_status
set_epic_param set_epic_param
params
end end
def set_health_status def set_health_status
......
...@@ -21,7 +21,7 @@ RSpec.describe Issuable::BulkUpdateService do ...@@ -21,7 +21,7 @@ RSpec.describe Issuable::BulkUpdateService do
end end
shared_examples 'does not update issuables attribute' do |attribute| shared_examples 'does not update issuables attribute' do |attribute|
it 'raises record not found error' do it 'does not update attribute' do
issuables.each do |issuable| issuables.each do |issuable|
expect { subject }.not_to change { issuable.send(attribute) } expect { subject }.not_to change { issuable.send(attribute) }
end end
...@@ -159,11 +159,7 @@ RSpec.describe Issuable::BulkUpdateService do ...@@ -159,11 +159,7 @@ RSpec.describe Issuable::BulkUpdateService do
stub_licensed_features(epics: false) stub_licensed_features(epics: false)
end end
it 'does not update issuables attribute' do it_behaves_like 'does not update issuables attribute', :labels
issuables.each do |issuable|
expect { subject }.not_to change { issuable.labels }
end
end
end end
context 'when issuable_ids contain external epics' do context 'when issuable_ids contain external epics' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment