Merge branch 'remove-projects_ci_sources_pipelines_project_id-fk' into 'master'

Swap FK ci_sources_pipelines to projects for LFK

See merge request gitlab-org/gitlab!79062

db/post_migrate/20220124204046_remove_projects_ci_sources_pipelines_project_id_fk.rb

+# frozen_string_literal: true
+
+class RemoveProjectsCiSourcesPipelinesProjectIdFk < Gitlab::Database::Migration[1.0]
+  disable_ddl_transaction!
+
+  def up
+    return unless foreign_key_exists?(:ci_sources_pipelines, :projects, name: "fk_1e53c97c0a")
+
+    with_lock_retries do
+      execute('LOCK projects, ci_sources_pipelines IN ACCESS EXCLUSIVE MODE') if transaction_open?
+
+      remove_foreign_key_if_exists(:ci_sources_pipelines, :projects, name: "fk_1e53c97c0a")
+    end
+  end
+
+  def down
+    add_concurrent_foreign_key(:ci_sources_pipelines, :projects, name: "fk_1e53c97c0a", column: :project_id, target_column: :id, on_delete: :cascade)
+  end
+end

db/schema_migrations/20220124204046

+90115936ede32bbf9a299582409cb0686e8072c204c4f91364dfb13195155929
\ No newline at end of file

db/structure.sql

@@ -29240,9 +29240,6 @@ ALTER TABLE ONLY agent_project_authorizations
 ALTER TABLE ONLY vulnerabilities
     ADD CONSTRAINT fk_1d37cddf91 FOREIGN KEY (epic_id) REFERENCES epics(id) ON DELETE SET NULL;
 
-ALTER TABLE ONLY ci_sources_pipelines
-    ADD CONSTRAINT fk_1e53c97c0a FOREIGN KEY (project_id) REFERENCES projects(id) ON DELETE CASCADE;
-
 ALTER TABLE ONLY boards
     ADD CONSTRAINT fk_1e9a074a35 FOREIGN KEY (group_id) REFERENCES namespaces(id) ON DELETE CASCADE;
 

lib/gitlab/database/gitlab_loose_foreign_keys.yml

@@ -177,6 +177,9 @@ ci_sources_pipelines:
   - table: projects
     column: source_project_id
     on_delete: async_delete
+  - table: projects
+    column: project_id
+    on_delete: async_delete
 ci_triggers:
   - table: users
     column: owner_id

spec/lib/gitlab/database/no_cross_db_foreign_keys_spec.rb

@@ -31,7 +31,6 @@ RSpec.describe 'cross-database foreign keys' do
       ci_runner_namespaces.namespace_id
       ci_runner_projects.project_id
       ci_running_builds.project_id
-      ci_sources_pipelines.project_id
       ci_sources_projects.source_project_id
       ci_stages.project_id
       ci_subscriptions_projects.downstream_project_id

spec/models/ci/sources/pipeline_spec.rb

@@ -24,4 +24,11 @@ RSpec.describe Ci::Sources::Pipeline do
       let!(:model) { create(:ci_sources_pipeline, source_project: parent) }
     end
   end
+
+  context 'loose foreign key on ci_sources_pipelines.project_id' do
+    it_behaves_like 'cleanup by a loose foreign key' do
+      let!(:parent) { create(:project) }
+      let!(:model) { create(:ci_sources_pipeline, project: parent) }
+    end
+  end
 end