Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ad5bf844
Commit
ad5bf844
authored
Sep 13, 2019
by
Ash McKenzie
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Call out Code Review in MR author responsibility
parent
f5724500
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
3 deletions
+3
-3
doc/development/code_review.md
doc/development/code_review.md
+3
-3
No files found.
doc/development/code_review.md
View file @
ad5bf844
...
@@ -87,9 +87,9 @@ Before assigning a merge request to a maintainer for approval and merge, they
...
@@ -87,9 +87,9 @@ Before assigning a merge request to a maintainer for approval and merge, they
should be confident that it actually solves the problem it was meant to solve,
should be confident that it actually solves the problem it was meant to solve,
that it does so in the most appropriate way, that it satisfies all requirements,
that it does so in the most appropriate way, that it satisfies all requirements,
and that there are no remaining bugs, logical problems, uncovered edge cases,
and that there are no remaining bugs, logical problems, uncovered edge cases,
or known vulnerabilities. The
merge request should also have a completed task
or known vulnerabilities. The
best way to do this, and to avoid unnecessary
list in its description and a passing CI pipeline to avoid unnecessary back and
back-and-forth with reviewers, is to perform a self-review of your own merge
forth
.
request, following the
[
Code Review
](
#reviewing-code
)
guidelines
.
To reach the required level of confidence in their solution, an author is expected
To reach the required level of confidence in their solution, an author is expected
to involve other people in the investigation and implementation processes as
to involve other people in the investigation and implementation processes as
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment