Merge branch 'remove-projects_ci_job_artifacts_project_id-fk' into 'master'

Swap FK ci_job_artifacts.project_id to projects for LFK

See merge request gitlab-org/gitlab!79026

db/post_migrate/20220124153233_remove_projects_ci_job_artifacts_project_id_fk.rb

+# frozen_string_literal: true
+
+class RemoveProjectsCiJobArtifactsProjectIdFk < Gitlab::Database::Migration[1.0]
+  disable_ddl_transaction!
+
+  def up
+    return if Gitlab.com? # unsafe migration, skip on GitLab.com due to https://gitlab.com/groups/gitlab-org/-/epics/7249#note_819625526
+    return unless foreign_key_exists?(:ci_job_artifacts, :projects, name: "fk_rails_9862d392f9")
+
+    with_lock_retries do
+      execute('LOCK projects, ci_job_artifacts IN ACCESS EXCLUSIVE MODE') if transaction_open?
+
+      remove_foreign_key_if_exists(:ci_job_artifacts, :projects, name: "fk_rails_9862d392f9")
+    end
+  end
+
+  def down
+    add_concurrent_foreign_key(:ci_job_artifacts, :projects, name: "fk_rails_9862d392f9", column: :project_id, target_column: :id, on_delete: :cascade)
+  end
+end

db/schema_migrations/20220124153233

+f62f3d4cc6f4704e7b4e7d0b6b8e46ed3de4407f0db4282e2ce845aa6c0b3f3f
\ No newline at end of file

db/structure.sql

@@ -30908,9 +30908,6 @@ ALTER TABLE ONLY group_repository_storage_moves
 ALTER TABLE ONLY resource_label_events
     ADD CONSTRAINT fk_rails_9851a00031 FOREIGN KEY (merge_request_id) REFERENCES merge_requests(id) ON DELETE CASCADE;
 
-ALTER TABLE ONLY ci_job_artifacts
-    ADD CONSTRAINT fk_rails_9862d392f9 FOREIGN KEY (project_id) REFERENCES projects(id) ON DELETE CASCADE;
-
 ALTER TABLE ONLY board_project_recent_visits
     ADD CONSTRAINT fk_rails_98f8843922 FOREIGN KEY (project_id) REFERENCES projects(id) ON DELETE CASCADE;
 

lib/gitlab/database/gitlab_loose_foreign_keys.yml

@@ -87,6 +87,10 @@ ci_build_report_results:
   - table: projects
     column: project_id
     on_delete: async_delete
+ci_job_artifacts:
+  - table: projects
+    column: project_id
+    on_delete: async_delete
 ci_builds:
   - table: users
     column: user_id

spec/lib/gitlab/database/no_cross_db_foreign_keys_spec.rb

@@ -15,7 +15,6 @@ RSpec.describe 'cross-database foreign keys' do
       ci_daily_build_group_report_results.group_id
       ci_daily_build_group_report_results.project_id
       ci_freeze_periods.project_id
-      ci_job_artifacts.project_id
       ci_job_token_project_scope_links.added_by_id
       ci_pending_builds.namespace_id
       ci_pending_builds.project_id

spec/models/ci/job_artifact_spec.rb

@@ -703,4 +703,11 @@ RSpec.describe Ci::JobArtifact do
   it_behaves_like 'it has loose foreign keys' do
     let(:factory_name) { :ci_job_artifact }
   end
+
+  context 'loose foreign key on ci_job_artifacts.project_id' do
+    it_behaves_like 'cleanup by a loose foreign key' do
+      let!(:parent) { create(:project) }
+      let!(:model) { create(:ci_job_artifact, project: parent) }
+    end
+  end
 end