Merge branch 'issue#325836-fix-empty-line-after-let-it-be-services-issues' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/services/issues

See merge request gitlab-org/gitlab!58425

.rubocop_manual_todo.yml

@@ -1013,12 +1013,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/services/incident_management/pager_duty/process_webhook_service_spec.rb
     - spec/services/integrations/test/project_service_spec.rb
     - spec/services/issuable/bulk_update_service_spec.rb
-    - spec/services/issues/build_service_spec.rb
-    - spec/services/issues/clone_service_spec.rb
-    - spec/services/issues/create_service_spec.rb
-    - spec/services/issues/export_csv_service_spec.rb
-    - spec/services/issues/move_service_spec.rb
-    - spec/services/issues/related_branches_service_spec.rb
     - spec/services/jira_connect/sync_service_spec.rb
     - spec/services/jira_import/start_import_service_spec.rb
     - spec/services/jira_import/users_importer_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-services-issues.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses in spec/services/issues
+merge_request: 58425
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/services/issues/build_service_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Issues::BuildService do
   let_it_be(:project) { create(:project, :repository) }
   let_it_be(:developer) { create(:user) }
   let_it_be(:guest) { create(:user) }
+
   let(:user) { developer }
 
   before_all do

spec/services/issues/clone_service_spec.rb

@@ -242,6 +242,7 @@ RSpec.describe Issues::CloneService do
 
       context 'issue with a design', :clean_gitlab_redis_shared_state do
         let_it_be(:new_project) { create(:project) }
+
         let!(:design) { create(:design, :with_lfs_file, issue: old_issue) }
         let!(:note) { create(:diff_note_on_design, noteable: design, issue: old_issue, project: old_issue.project) }
         let(:subject) { clone_service.execute(old_issue, new_project) }

spec/services/issues/create_service_spec.rb

@@ -11,6 +11,7 @@ RSpec.describe Issues::CreateService do
   describe '#execute' do
     let_it_be(:assignee) { create(:user) }
     let_it_be(:milestone) { create(:milestone, project: project) }
+
     let(:issue) { described_class.new(project, user, opts).execute }
 
     context 'when params are valid' do

spec/services/issues/export_csv_service_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe Issues::ExportCsvService do
   let_it_be(:project) { create(:project, :public, group: group) }
   let_it_be(:issue) { create(:issue, project: project, author: user) }
   let_it_be(:bad_issue) { create(:issue, project: project, author: user) }
+
   subject { described_class.new(Issue.all, project) }
 
   it 'renders csv to string' do

spec/services/issues/move_service_spec.rb

@@ -206,6 +206,7 @@ RSpec.describe Issues::MoveService do
 
       context 'issue with a design', :clean_gitlab_redis_shared_state do
         let_it_be(:new_project) { create(:project) }
+
         let!(:design) { create(:design, :with_lfs_file, issue: old_issue) }
         let!(:note) { create(:diff_note_on_design, noteable: design, issue: old_issue, project: old_issue.project) }
         let(:subject) { move_service.execute(old_issue, new_project) }

spec/services/issues/related_branches_service_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Issues::RelatedBranchesService do
   let_it_be(:developer) { create(:user) }
   let_it_be(:issue) { create(:issue) }
+
   let(:user) { developer }
 
   subject { described_class.new(issue.project, user) }