Merge branch 'fix-automated-review-app-cleanup' into 'master'

Don't try to delete non-existing K8s resources

See merge request gitlab-org/gitlab!58368

spec/tooling/lib/tooling/kubernetes_client_spec.rb

@@ -123,6 +123,16 @@ RSpec.describe Tooling::KubernetesClient do
 
       it_behaves_like 'a kubectl command to delete resources by older than given creation time'
     end
+
+    context 'with no resources found' do
+      let(:resource_names) { [] }
+
+      it 'does not call #delete_by_exact_names' do
+        expect(subject).not_to receive(:delete_by_exact_names)
+
+        subject.cleanup_by_created_at(resource_type: resource_type, created_before: two_days_ago)
+      end
+    end
   end
 
   describe '#raw_resource_names' do

tooling/lib/tooling/kubernetes_client.rb

@@ -22,6 +22,8 @@ module Tooling
 
     def cleanup_by_created_at(resource_type:, created_before:, wait: true)
       resource_names = resource_names_created_before(resource_type: resource_type, created_before: created_before)
+      return if resource_names.empty?
+
       delete_by_exact_names(resource_type: resource_type, resource_names: resource_names, wait: wait)
     end