Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
afa7582b
Commit
afa7582b
authored
Feb 08, 2021
by
Alper Akgun
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Record conversion for 3 experiment in onboarding flow
parent
41f2d403
Changes
6
Show whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
17 additions
and
0 deletions
+17
-0
ee/app/controllers/registrations/groups_controller.rb
ee/app/controllers/registrations/groups_controller.rb
+5
-0
ee/app/controllers/registrations/projects_controller.rb
ee/app/controllers/registrations/projects_controller.rb
+1
-0
ee/app/controllers/trials_controller.rb
ee/app/controllers/trials_controller.rb
+2
-0
ee/spec/controllers/registrations/groups_controller_spec.rb
ee/spec/controllers/registrations/groups_controller_spec.rb
+5
-0
ee/spec/controllers/registrations/projects_controller_spec.rb
...pec/controllers/registrations/projects_controller_spec.rb
+1
-0
ee/spec/controllers/trials_controller_spec.rb
ee/spec/controllers/trials_controller_spec.rb
+3
-0
No files found.
ee/app/controllers/registrations/groups_controller.rb
View file @
afa7582b
...
...
@@ -30,6 +30,11 @@ module Registrations
record_experiment_user
(
:remove_known_trial_form_fields
,
namespace_id:
@group
.
id
)
record_experiment_user
(
:trimmed_skip_trial_copy
,
namespace_id:
@group
.
id
)
record_experiment_user
(
:trial_registration_with_social_signin
,
namespace_id:
@group
.
id
)
record_experiment_user
(
:trial_onboarding_issues
,
namespace_id:
@group
.
id
)
record_experiment_conversion_event
(
:remove_known_trial_form_fields
)
record_experiment_conversion_event
(
:trimmed_skip_trial_copy
)
record_experiment_conversion_event
(
:trial_registration_with_social_signin
)
record_experiment_conversion_event
(
:trial_onboarding_issues
)
url_params
[
:trial_onboarding_flow
]
=
true
else
...
...
ee/app/controllers/registrations/projects_controller.rb
View file @
afa7582b
...
...
@@ -27,6 +27,7 @@ module Registrations
}
record_experiment_user
(
:trial_onboarding_issues
,
trial_onboarding_context
)
record_experiment_conversion_event
(
:trial_onboarding_issues
)
redirect_to
trial_getting_started_users_sign_up_welcome_path
(
learn_gitlab_project_id:
learn_gitlab_project
.
id
)
else
redirect_to
users_sign_up_experience_level_path
(
namespace_path:
@project
.
namespace
,
trial_onboarding_flow:
params
[
:trial_onboarding_flow
])
...
...
ee/app/controllers/trials_controller.rb
View file @
afa7582b
...
...
@@ -44,9 +44,11 @@ class TrialsController < ApplicationController
record_experiment_user
(
:remove_known_trial_form_fields
,
namespace_id:
@namespace
.
id
)
record_experiment_user
(
:trimmed_skip_trial_copy
,
namespace_id:
@namespace
.
id
)
record_experiment_user
(
:trial_registration_with_social_signin
,
namespace_id:
@namespace
.
id
)
record_experiment_user
(
:trial_onboarding_issues
,
namespace_id:
@namespace
.
id
)
record_experiment_conversion_event
(
:remove_known_trial_form_fields
)
record_experiment_conversion_event
(
:trimmed_skip_trial_copy
)
record_experiment_conversion_event
(
:trial_registration_with_social_signin
)
record_experiment_conversion_event
(
:trial_onboarding_issues
)
redirect_to
group_url
(
@namespace
,
{
trial:
true
})
else
...
...
ee/spec/controllers/registrations/groups_controller_spec.rb
View file @
afa7582b
...
...
@@ -236,6 +236,11 @@ RSpec.describe Registrations::GroupsController do
expect
(
controller
).
to
receive
(
:record_experiment_user
).
with
(
:remove_known_trial_form_fields
,
namespace_id:
group
.
id
)
expect
(
controller
).
to
receive
(
:record_experiment_user
).
with
(
:trimmed_skip_trial_copy
,
namespace_id:
group
.
id
)
expect
(
controller
).
to
receive
(
:record_experiment_user
).
with
(
:trial_registration_with_social_signin
,
namespace_id:
group
.
id
)
expect
(
controller
).
to
receive
(
:record_experiment_user
).
with
(
:trial_onboarding_issues
,
namespace_id:
group
.
id
)
expect
(
controller
).
to
receive
(
:record_experiment_conversion_event
).
with
(
:remove_known_trial_form_fields
)
expect
(
controller
).
to
receive
(
:record_experiment_conversion_event
).
with
(
:trimmed_skip_trial_copy
)
expect
(
controller
).
to
receive
(
:record_experiment_conversion_event
).
with
(
:trial_registration_with_social_signin
)
expect
(
controller
).
to
receive
(
:record_experiment_conversion_event
).
with
(
:trial_onboarding_issues
)
is_expected
.
to
redirect_to
(
new_users_sign_up_project_path
(
namespace_id:
group
.
id
,
trial:
false
,
trial_onboarding_flow:
true
))
end
...
...
ee/spec/controllers/registrations/projects_controller_spec.rb
View file @
afa7582b
...
...
@@ -99,6 +99,7 @@ RSpec.describe Registrations::ProjectsController do
expect
(
service
).
to
receive
(
:execute
).
and_return
(
project
)
end
expect
(
controller
).
to
receive
(
:record_experiment_user
).
with
(
:trial_onboarding_issues
,
trial_onboarding_context
)
expect
(
controller
).
to
receive
(
:record_experiment_conversion_event
).
with
(
:trial_onboarding_issues
)
expect
(
subject
).
to
redirect_to
(
trial_getting_started_users_sign_up_welcome_path
(
learn_gitlab_project_id:
project
.
id
))
end
end
...
...
ee/spec/controllers/trials_controller_spec.rb
View file @
afa7582b
...
...
@@ -111,6 +111,7 @@ RSpec.describe TrialsController do
it
'records trial_onboarding_issues experiment users and redirects to onboarding'
do
expect
(
controller
).
to
receive
(
:record_experiment_user
).
with
(
:trial_onboarding_issues
)
is_expected
.
to
redirect_to
(
new_users_sign_up_group_path
(
glm_source:
'about.gitlab.com'
,
trial_onboarding_flow:
true
))
end
end
...
...
@@ -229,9 +230,11 @@ RSpec.describe TrialsController do
expect
(
controller
).
to
receive
(
:record_experiment_user
).
with
(
:remove_known_trial_form_fields
,
namespace_id:
namespace
.
id
)
expect
(
controller
).
to
receive
(
:record_experiment_user
).
with
(
:trimmed_skip_trial_copy
,
namespace_id:
namespace
.
id
)
expect
(
controller
).
to
receive
(
:record_experiment_user
).
with
(
:trial_registration_with_social_signin
,
namespace_id:
namespace
.
id
)
expect
(
controller
).
to
receive
(
:record_experiment_user
).
with
(
:trial_onboarding_issues
,
namespace_id:
namespace
.
id
)
expect
(
controller
).
to
receive
(
:record_experiment_conversion_event
).
with
(
:remove_known_trial_form_fields
)
expect
(
controller
).
to
receive
(
:record_experiment_conversion_event
).
with
(
:trimmed_skip_trial_copy
)
expect
(
controller
).
to
receive
(
:record_experiment_conversion_event
).
with
(
:trial_registration_with_social_signin
)
expect
(
controller
).
to
receive
(
:record_experiment_conversion_event
).
with
(
:trial_onboarding_issues
)
subject
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment